Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for setting stripe size for LVM RAID #357

Merged

Conversation

vojtechtrefny
Copy link
Collaborator

Custom stripe size is required for SAP HANA setups.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (6388626) 13.90% compared to head (8adb941) 13.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   13.90%   13.86%   -0.04%     
==========================================
  Files           8        8              
  Lines        1705     1709       +4     
  Branches       71       71              
==========================================
  Hits          237      237              
- Misses       1468     1472       +4     
Flag Coverage Δ
sanity 16.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
library/blivet.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richm
Copy link
Contributor

richm commented May 31, 2023

[citest]

@vojtechtrefny
Copy link
Collaborator Author

The tests are now failing with

failed to set up volume 'lv1': __init__() got an unexpected keyword argument 'stripe_size'

because we don't have the latest version of blivet (which adds support for setting stripe_size for LVs), but the test should be skipped in this case. I am not sure why the version based skipping isn't working here correctly, I am looking into this.

Custom stripe size is required for SAP HANA setups.
@vojtechtrefny
Copy link
Collaborator Author

The tests are now failing with

failed to set up volume 'lv1': __init__() got an unexpected keyword argument 'stripe_size'

because we don't have the latest version of blivet (which adds support for setting stripe_size for LVs), but the test should be skipped in this case. I am not sure why the version based skipping isn't working here correctly, I am looking into this.

The skipping of the stripe size test case works correctly, this was actually a bug -- I was passing the stripe_size option even if stripe size wasn't specified so all the test cases were failing with old blivet. This should be fixed now.

@vojtechtrefny
Copy link
Collaborator Author

[citest]

1 similar comment
@richm
Copy link
Contributor

richm commented Jun 2, 2023

[citest]

@richm richm merged commit 3641c64 into linux-system-roles:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants