Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for setting stripe size for LVM RAID #355

Conversation

vojtechtrefny
Copy link
Collaborator

Custom stripe size is needed for SAP HANA. We are using here the existing 'raid_chunk_size' property, the "chunk size" term comes from MD RAID where it has the same meaning as "stripe size" for LVM RAID.

Custom stripe size is needed for SAP HANA. We are using here the
existing 'raid_chunk_size' property, the "chunk size" term comes
from MD RAID where it has the same meaning as "stripe size" for
LVM RAID.
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (1b4b4c5) 13.90% compared to head (b34c7f7) 13.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   13.90%   13.88%   -0.02%     
==========================================
  Files           8        8              
  Lines        1705     1707       +2     
  Branches       71       71              
==========================================
  Hits          237      237              
- Misses       1468     1470       +2     
Flag Coverage Δ
sanity 16.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
library/blivet.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vojtechtrefny
Copy link
Collaborator Author

I decided to reuse the raid_chunk_size argument for the LVM RAID stripe size here. I am not 100 % sure this is the best approach -- I wanted to avoid adding another LVM RAID specific argument when chunk and stripe size is basically the same thing in MD and LVM RAID, but it might be confusing. @dwlehman @richm what do you think?

@richm
Copy link
Contributor

richm commented May 17, 2023

I decided to reuse the raid_chunk_size argument for the LVM RAID stripe size here. I am not 100 % sure this is the best approach -- I wanted to avoid adding another LVM RAID specific argument when chunk and stripe size is basically the same thing in MD and LVM RAID, but it might be confusing. @dwlehman @richm what do you think?

I would prefer to have some parameter with stripe_size in the name, but if 1) it will be difficult to add a new parameter and 2) storage admins will know that chunk_size and stripe_size are the same concept, then works for me. @briansmith0 wdyt?

@briansmith0
Copy link

+1 to the comment from @richm

@vojtechtrefny
Copy link
Collaborator Author

Thank you for the feedback, I didn't realize that chunk size is also used by LVM for thin pools so using it for RAID could be confusing. #357 is replacement for this adding a new raid_stripe_size argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants