Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor misc fixes in tls_key() #2537

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minor misc fixes in tls_key() #2537

wants to merge 4 commits into from

Commits on Oct 16, 2024

  1. nvme: modify err message if keyfile does not exist 

    Trivial fix to avoid printing an additional blank line if the
keyfile does not exist.

Signed-off-by: Martin George <marting@netapp.com>
    @martin-gpy
    martin-gpy committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b2e0ed4 View commit details
    Browse the repository at this point in the history

  2. nvme: update tls_key export handling 

    Few issues with current export handling:

1) No check to see if cfg.keyfile is provided. This could lead to
incorrect export handling.

2) nvme_scan_tls_keys() can return positive values too for
successful scenarios. So return value handling needs to be modified
accordingly.

3) No helpful success message printed for proper export handling.

Fix the same.

Signed-off-by: Martin George <marting@netapp.com>
    @martin-gpy
    martin-gpy committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5e02091 View commit details
    Browse the repository at this point in the history

  3. nvme: update tls_key import handling 

    Few issues with current import handling:

1) No check to see if cfg.keyfile is provided. This could lead to a
hang when running the import option.

2) No return value checking for import_key() failure scenarios.

3) No helpful success message printed for proper import handling.

Fix the same.

Signed-off-by: Martin George <marting@netapp.com>
    @martin-gpy
    martin-gpy committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d8ad0cd View commit details
    Browse the repository at this point in the history

  4. nvme: update tls_key revoke handling 

    Print a helpful success message for proper revoke handling. And
also return the appropriate error when nvme_revoke_tls_key() fails.

Signed-off-by: Martin George <marting@netapp.com>
    @martin-gpy
    martin-gpy committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    64f97d6 View commit details
    Browse the repository at this point in the history