Minor misc fixes in tls_key() #2537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivial fix to avoid printing an additional blank line if the keyfile does not exist. Signed-off-by: Martin George <marting@netapp.com>
Few issues with current export handling: 1) No check to see if cfg.keyfile is provided. This could lead to incorrect export handling. 2) nvme_scan_tls_keys() can return positive values too for successful scenarios. So return value handling needs to be modified accordingly. 3) No helpful success message printed for proper export handling. Fix the same. Signed-off-by: Martin George <marting@netapp.com>
Few issues with current import handling: 1) No check to see if cfg.keyfile is provided. This could lead to a hang when running the import option. 2) No return value checking for import_key() failure scenarios. 3) No helpful success message printed for proper import handling. Fix the same. Signed-off-by: Martin George <marting@netapp.com>
Print a helpful success message for proper revoke handling. And also return the appropriate error when nvme_revoke_tls_key() fails. Signed-off-by: Martin George <marting@netapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.