Skip to content
This repository was archived by the owner on Jul 21, 2021. It is now read-only.

Feature pipeline changes + DEV language extactor #4

Merged
merged 14 commits into from
Dec 13, 2016

Conversation

BlackDark
Copy link
Collaborator

No description provided.

@BlackDark BlackDark requested a review from linkvt December 10, 2016 15:59
return self.clf.predict(samples)

def __map_input__(self, samples):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warum 2 _? Also nachdem was ich gelesen hab soll __ "privater" als _ sein, habs aber noch nie so gesehen und man liest auch dass mans eher nicht verwendet sollte

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keine Ahnung, ich hab mich nicht mit conventions von python befasst :D

"""
The languages returned from github are mapped to the kb size of usage.
Eq {'Python': 98564, 'R': 4914}
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echt?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


for language in self.__get_relevant_languages__():
if language in languages:
relevant_size += languages[language]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist glaube nicht case insensitive

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicht case insensitive -> case sensitive? Ist es ja. Zumindest sind die verfügbaren Sprachen ja vordefiniert. Wir könnten auch alles defensiv gestalten.

BlackDark and others added 6 commits December 11, 2016 01:52
Will be probably be merged into one FeatureExtractor
This one should not be used with the normal decision tree because we have a total of 223 features with this one only.
Add categories to the feature extraction in order to split feature "b…
@BlackDark BlackDark merged commit bb970f0 into master Dec 13, 2016
@linkvt linkvt deleted the feature-pipeline-changes branch December 13, 2016 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants