This repository was archived by the owner on Jul 21, 2021. It is now read-only.
Add categories to the feature extraction in order to split feature "b… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkvt
reviewed
Dec 13, 2016
| def __init__(self, repo): | ||
| self.repo = repo | ||
| self.categories = self._get_categories() | ||
| self.weight = self._get_weight() |
There was a problem hiding this comment.
Verstehe die zwei Zeilen nicht, wieso in Gettern?
linkvt
reviewed
Dec 13, 2016
|
|
||
| def extract(self) -> [Feature]: | ||
| if self.categories: | ||
| return list(itertools.chain.from_iterable((category.extract() for category in self.categories))) |
There was a problem hiding this comment.
das mit den genesteten Imports wuerde ich mit chain.from_iterable machen, ist kuerzer und sagt das gleiche
linkvt
reviewed
Dec 13, 2016
| feature in FEATURE_ORDER] | ||
| def extract_features(self) -> [Feature]: | ||
| return list( | ||
| itertools.chain.from_iterable((category.extract() for category in self.extract_features_in_categories()))) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…undles"