create bridge with type #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Lin
force-pushed
the
johnlin/create-br-with-type
branch
from
93cfa58
to
8fea1a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 7 7
Lines 182 182
=======================================
Hits 154 154
Misses 17 17
Partials 11 11
Continue to review full report at Codecov.
|
chenyunchen
approved these changes
Jun 28, 2018
zyfdegh
reviewed
Jun 28, 2018
openvswitch/ovs_test.go
Outdated
| @@ -62,7 +63,8 @@ func TestBridgeOperationsFail(t *testing.T) { | |||
| assert.Error(t, err) | |||
|
|
|||
| bridgeName := "br0" | |||
| err = o.CreateBridge(bridgeName) | |||
| dpType := "system" | |||
There was a problem hiding this comment.
A better idea is to use constants to enumerate all the types. That's
const DatapathTypeSystem = "system"
0ce000a
to
103e6a0
Compare
c9s
approved these changes
Jun 29, 2018
|
looks good, can you rebase and squash ? you can use "fixup" |
John-Lin
force-pushed
the
johnlin/create-br-with-type
branch
from
103e6a0
to
82c7704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.