change to constant

linkernetworks · Jun 28, 2018 · 0ce000a · 0ce000a
1 parent 9920bdd
commit 0ce000a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/nl/netlink_handler_test.go b/nl/netlink_handler_test.go
@@ -26,8 +26,8 @@ func TestRemoveVethFromOVS(t *testing.T) {
 	assert.Equal(t, 0, len(bridges))
 
 	bridgeName := "br0"
-	dpType := "system"
-	err = o.CreateBridge(bridgeName, dpType)
+	const dpTypeSystem = "system"
+	err = o.CreateBridge(bridgeName, dpTypeSystem)
 	defer o.DeleteBridge(bridgeName)
 	assert.NoError(t, err)
 

diff --git a/openvswitch/ovs_test.go b/openvswitch/ovs_test.go
@@ -39,8 +39,8 @@ func TestBridgeOperations(t *testing.T) {
 	assert.Equal(t, 0, len(bridges))
 
 	bridgeName := "br0"
-	dpType := "system"
-	err = o.CreateBridge(bridgeName, dpType)
+	const dpTypeSystem = "system"
+	err = o.CreateBridge(bridgeName, dpTypeSystem)
 	assert.NoError(t, err)
 
 	bridges, err = o.ListBridges()
@@ -63,8 +63,8 @@ func TestBridgeOperationsFail(t *testing.T) {
 	assert.Error(t, err)
 
 	bridgeName := "br0"
-	dpType := "system"
-	err = o.CreateBridge(bridgeName, dpType)
+	const dpTypeSystem = "system"
+	err = o.CreateBridge(bridgeName, dpTypeSystem)
 	assert.Error(t, err)
 
 	_, err = o.ListBridges()
@@ -76,8 +76,8 @@ func TestBridgeOperationsFail(t *testing.T) {
 
 func TestAddDelPort(t *testing.T) {
 	bridgeName := "br0"
-	dpType := "system"
-	err := o.CreateBridge(bridgeName, dpType)
+	const dpTypeSystem = "system"
+	err := o.CreateBridge(bridgeName, dpTypeSystem)
 	defer o.DeleteBridge(bridgeName)
 
 	hName := "test0"
@@ -123,8 +123,8 @@ func TestAddDelPortFail(t *testing.T) {
 
 func TestFlowOperation(t *testing.T) {
 	bridgeName := "br0"
-	dpType := "system"
-	err := o.CreateBridge(bridgeName, dpType)
+	const dpTypeSystem = "system"
+	err := o.CreateBridge(bridgeName, dpTypeSystem)
 	defer o.DeleteBridge(bridgeName)
 	assert.NoError(t, err)
 
@@ -157,8 +157,8 @@ func TestFlowOperationsFail(t *testing.T) {
 
 func TestDumpPorts(t *testing.T) {
 	bridgeName := "br0"
-	dpType := "system"
-	err := o.CreateBridge(bridgeName, dpType)
+	const dpTypeSystem = "system"
+	err := o.CreateBridge(bridgeName, dpTypeSystem)
 	defer o.DeleteBridge(bridgeName)
 
 	hName := "test0"