Fix golint errors #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: - Line 1: warning: package comment should be of the form "Package nl ..." (golint)
Fix: - Line 14: warning: exported type PodOptions should have comment or be unexported (golint) - Line 20: warning: exported type InterfaceOptions should have comment or be unexported (golint) - Line 26: warning: exported type ConnectOptions should have comment or be unexported (golint) - Line 31: warning: exported type ClientOptions should have comment or be unexported (golint)
Fix: - Line 9: warning: comment on exported function RemoveVethFromOVS should be of the form "RemoveVethFromOVS ..." (golint)
Rename LinkReceiver to linkReceiver Fix Line 14: warning: exported type LinkReceiver should have comment or be unexported (golint)
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 86.81% 86.95% +0.14%
==========================================
Files 7 7
Lines 182 184 +2
==========================================
+ Hits 158 160 +2
Misses 15 15
Partials 9 9
Continue to review full report at Codecov.
|
John-Lin
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #34
nl/netlink_event.go,nl/netlink_handler.go,client/main.go,nl/link.gogolint errorsnl/netlink_event.goneed to be fixed soon, because the function name effect to main function.