Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint warning #34

Closed
hwchiu opened this issue Jun 11, 2018 · 1 comment
Closed

Fix golint warning #34

hwchiu opened this issue Jun 11, 2018 · 1 comment
Assignees
@sufuf3
Labels
enhancement New feature or request

Comments

@hwchiu
Copy link
Contributor

hwchiu commented Jun 11, 2018

Refer to https://goreportcard.com/report/github.com/linkernetworks/network-controller
@hwchiu hwchiu added the enhancement New feature or request label Jun 11, 2018
@sufuf3 sufuf3 self-assigned this Jun 12, 2018
sufuf3 added a commit that referenced this issue Jun 12, 2018
@sufuf3
Fix nl/link.go golint error, cc #34
85f6893 
Fix:
- Line 1: warning: package comment should be of the form "Package nl
  ..." (golint)
sufuf3 added a commit that referenced this issue Jun 12, 2018
@sufuf3
Fix client/main.go golint errors, cc #34
4f2c98a 
Fix:
- Line 14: warning: exported type PodOptions should have comment or be
unexported (golint)
- Line 20: warning: exported type InterfaceOptions should have comment
or be unexported (golint)
- Line 26: warning: exported type ConnectOptions should have comment or
be unexported (golint)
- Line 31: warning: exported type ClientOptions should have comment or
be unexported (golint)
sufuf3 added a commit that referenced this issue Jun 12, 2018
@sufuf3
Fix nl/netlink_handler.go golint error, cc #34
1aa8611 
Fix:
- Line 9: warning: comment on exported function RemoveVethFromOVS should
be of the form "RemoveVethFromOVS ..." (golint)
sufuf3 added a commit that referenced this issue Jun 12, 2018
@sufuf3
Fix nl/netlink_event.go golint error, cc #34
5e7ed55 
Rename LinkReceiver to linkReceiver
Fix Line 14: warning: exported type LinkReceiver should have comment or
be unexported (golint)
@sufuf3 sufuf3 mentioned this issue Jun 12, 2018
Merged
@hwchiu hwchiu closed this as completed Jun 12, 2018
@hwchiu
Copy link
Contributor Author

hwchiu commented Jun 12, 2018

Done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sufuf3 sufuf3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hwchiu @sufuf3