Skip to content

Support "Channel access token v2.1" #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2022

Conversation

yingtung
Copy link
Contributor

  • implement new functions issue_channel_access_token_v2_1, revoke_channel_access_token_v2_1, get_channel_access_tokens_v2_1 in linebot/api.py

  • implement a new response IssueChannelTokenResponseV2 and ChannelAccessTokens in linebot/models/responses.py

Closes #254

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yingtung
❌ chloechen


chloechen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yingtung yingtung force-pushed the feature/channel-token-v2.1 branch 2 times, most recently from 3d9acc1 to 695b7c5 Compare March 1, 2022 15:51
@yingtung yingtung force-pushed the feature/channel-token-v2.1 branch from 695b7c5 to b6c2920 Compare March 1, 2022 16:00
@louis70109
Copy link
Member

louis70109 commented Mar 2, 2022

Thanks @yingtung for developing, will check this PR.

If anyone has some comment, please let us know. :)

@louis70109
Copy link
Member

@yingtung Everything is good for us.
Could you implement the following two Channel Access APIs to make SDK perfect?

@yingtung
Copy link
Contributor Author

@louis70109 I implemented these two apis
Verify the validity of the channel access token v2.1
Get all valid channel access token key IDs v2.1
Please check this pr again, thanks.

@yingtung yingtung force-pushed the feature/channel-token-v2.1 branch from c1ddb37 to 70479ad Compare March 12, 2022 13:56
@louis70109
Copy link
Member

Hi @yingtung.

Ummm, I didn't find them on Files changed page.
Do you forget to push commit?

@yingtung yingtung force-pushed the feature/channel-token-v2.1 branch from 70479ad to c1ddb37 Compare March 13, 2022 15:21
@yingtung
Copy link
Contributor Author

hi @louis70109 , sorry for my mistake.
I have pushed the new commit.

Copy link
Member

@louis70109 louis70109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🤩

@louis70109 louis70109 merged commit c9876c5 into line:master Mar 14, 2022
@yingtung yingtung deleted the feature/channel-token-v2.1 branch March 14, 2022 14:33
louis70109 added a commit that referenced this pull request Mar 24, 2022
- Support statistics per aggregation unit (#373) @Yang-33 
- Flex message update 3 (#375) @intactio 
- Support "Channel access token v2.1" (#372)  @yingtung 
- Add fastapi example (#342) @wasdee
louis70109 added a commit that referenced this pull request Mar 24, 2022
- Support statistics per aggregation unit (#373) @Yang-33 
- Flex message update 3 (#375) @intactio 
- Support "Channel access token v2.1" (#372)  @yingtung 
- Add fastapi example (#342) @wasdee
@louis70109 louis70109 mentioned this pull request Mar 24, 2022
louis70109 added a commit that referenced this pull request Mar 28, 2022
- Support statistics per aggregation unit (#373) @Yang-33 
- Flex message update 3 (#375) @intactio 
- Support "Channel access token v2.1" (#372)  @yingtung 
- Add fastapi example (#342) @wasdee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Channel access token v2.1
3 participants