Skip to content

Async-support-fastapi-sample #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ninyawee
Copy link

@ninyawee ninyawee commented Oct 4, 2021

create for #340 to add fastapi sample

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@clsung clsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files (i.e. aiohttp_async_http_client.py, async_api.py) are already committed in #340?

@ninyawee ninyawee force-pushed the async-support-fastapi-sample branch from b0b9581 to 4f39cc9 Compare October 30, 2021 02:29
@ninyawee
Copy link
Author

ninyawee commented Oct 30, 2021

Some files (i.e. aiohttp_async_http_client.py, async_api.py) are already committed in #340?

I reseted and added changes on top of master.

@ninyawee
Copy link
Author

could you add this as a part of hacktoberfest. more info here

Copy link
Member

@louis70109 louis70109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis70109 louis70109 merged commit 394bc06 into line:master Mar 15, 2022
@louis70109 louis70109 mentioned this pull request Mar 15, 2022
louis70109 added a commit that referenced this pull request Mar 24, 2022
- Support statistics per aggregation unit (#373) @Yang-33 
- Flex message update 3 (#375) @intactio 
- Support "Channel access token v2.1" (#372)  @yingtung 
- Add fastapi example (#342) @wasdee
louis70109 added a commit that referenced this pull request Mar 24, 2022
- Support statistics per aggregation unit (#373) @Yang-33 
- Flex message update 3 (#375) @intactio 
- Support "Channel access token v2.1" (#372)  @yingtung 
- Add fastapi example (#342) @wasdee
@louis70109 louis70109 mentioned this pull request Mar 24, 2022
louis70109 added a commit that referenced this pull request Mar 28, 2022
- Support statistics per aggregation unit (#373) @Yang-33 
- Flex message update 3 (#375) @intactio 
- Support "Channel access token v2.1" (#372)  @yingtung 
- Add fastapi example (#342) @wasdee
@i-Ching
Copy link

i-Ching commented Apr 8, 2022

I replace aiohttp.ClientSession() with httpx.AsyncClient(), it works.
Hence I don't need import aiohttp under FastAPI or starlette environment.

import httpx
session = httpx.AsyncClient()
async_http_client = AiohttpAsyncHttpClient(session)
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants