Add version.ts instead of importing package.json in source code #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
approved these changes
May 8, 2025
Contributor
|
(this should be released) |
kkdai
pushed a commit
to kkdai/line-bot-mcp-server
that referenced
this pull request
May 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withsyntax in import pkg from "../package.json" with { type: "json" }; has been available since Node v20.10. On the other hand, the olderassertsyntax in import pkg from "../package.json" assert { type: "json" }; cannot be used in Node v22 or later. Therefore, there is no way to support both v20.9 and below, and v22 and above at the same time.Since we want to support both versions in line-bot-mcp-server, we decided to stop importing package.json directly. Instead, version.ts is now used.
The version in version.ts is automatically updated by GitHub Actions at release.