Update Node.js version requirement to v20.10 or later #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
reviewed
May 7, 2025
There was a problem hiding this comment.
Can't we fully support Node.js v20? If this just wants to read the version, we could create a version.ts instead of relying on package.json. The version can be updated with scripts, so we can update version.ts at the same time. This is simple (and exactly the same approach used by line-bot-sdk-nodejs, with very low maintenance costs).
The advantage of this approach is that it eliminates behavior dependent on the Node.js version and also supports v20.x.y below v20.10. This should be beneficial for users as well.
There was a problem hiding this comment.
I agree totally.
I'll close this PR and open new PR handling it.
#61
|
Handle this issue in #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be precise, Node.js needs to be version 20.10 or higher, so I have made the correction.
The
withsyntax is available in Node.js v20.10 and above. Therefore, if you use v20.9 or below, a runtime error will occur.https://github.com/line/line-bot-mcp-server/blob/b5c4570dba898dc24c0fd678e413d367e0ec6bb0/src/index.ts
nodejs/node#50140
On the other hand, the older syntax
asserthas been deprecated since v22, and you need to usewithinstead.nodejs/node#52104
In order to support Node.js v22 and above in this repository, we will use
withand, as a result, only support Node.js v20.10 or higher.