Rebasing Dockerfiles changes to develop branch.
#2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 6, 2022 17:44
This will make docker builds use less layers for building images. Build time will also be increased (due to caching for fewer layers) Moved nginx images to multi-stage build and restructured the build steps
RomaricMourgues
added
the
priority:1
RomaricMourgues
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Refactored Dockerfiles to reduce excessive RUNs This will make docker builds use less layers for building images. Build time will also be increased (due to caching for fewer layers) Moved nginx images to multi-stage build and restructured the build steps * Readded missing slash * Modified the compose for local development * Changed to latest LTS and force legacy peer deps
RomaricMourgues
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Refactored Dockerfiles to reduce excessive RUNs This will make docker builds use less layers for building images. Build time will also be increased (due to caching for fewer layers) Moved nginx images to multi-stage build and restructured the build steps * Readded missing slash * Modified the compose for local development * Changed to latest LTS and force legacy peer deps
RomaricMourgues
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Refactored Dockerfiles to reduce excessive RUNs This will make docker builds use less layers for building images. Build time will also be increased (due to caching for fewer layers) Moved nginx images to multi-stage build and restructured the build steps * Readded missing slash * Modified the compose for local development * Changed to latest LTS and force legacy peer deps
github-actions
bot
removed
staging:develop
priority:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @RomaricMourgues here: #2636 (comment)
This closes #2636