Refactored Dockerfiles to reduce excessive RUNs #2636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2022 12:02
This will make docker builds use less layers for building images. Build time will also be increased (due to caching for fewer layers) Moved nginx images to multi-stage build and restructured the build steps
Contributor
|
Awesome idea ! |
|
nice change, |
Contributor
Author
|
This PR should be ready now 👍 |
RomaricMourgues
approved these changes
Dec 5, 2022
Contributor
|
Could you rebase it to the "develop" branch first ? All PR must be opened on the "develop" branch first and then when merged they will be added to all the environments up to main. |
RomaricMourgues
suggested changes
Dec 5, 2022
Contributor
RomaricMourgues
left a comment
RomaricMourgues
left a comment
There was a problem hiding this comment.
Rebase on branch "develop"
Contributor
Author
|
Sure. Should I open a new PR then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make docker builds use less layers for building images.
Build time will also be increased (due to caching for fewer layers).
I also refactored nginx image to use multi-stage build and restructured the build steps for other images.
Please test to see if these changes are not breaking anything. It should not be, but there might be some small problems 😅