-
Notifications
You must be signed in to change notification settings - Fork 669
Implement the suspend and resume commands #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested with default instance and a busy loop, which went "silent" after putting the instance into pause. There might be an issue with ssh getting disconnected if sleeping too long, but can be fixed by a restart. |
I think we should switch away from sshfs to 9p before merging this PR. |
I agree, but the volume mounts are not the only part affected by SSH disconnects. Unix socket forwarding is also sometimes breaking when the host is sleeping. I hope to look into this whole topic (host sleeping) next week, but I still have hopes that 9p would solve/improve other issues, like performance. |
Actually I meant the guest sleeping (i.e. "pause"), suspending the host probably has similar (or worse) issues. |
e8fc546
to
e2f611c
Compare
e2f611c
to
cf98c73
Compare
3f47c79
to
107974a
Compare
107974a
to
15cdae7
Compare
15cdae7
to
8f033e2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Maybe a new method to reset/restore all networking ? |
74f0a79
to
5b537e4
Compare
09c18c7
to
ef8f24e
Compare
For halting the emulation and putting the VM into paused run state. Also query the status of running instances, when showing in "list". Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
ef8f24e
to
f5286f1
Compare
For halting the emulation and putting the VM into paused run state.
Also query the status of running instances, when showing in "list".
Closes #598