Move hostagent command to separate binary #1210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows linking only the hostagent with the driver libraries, while keeping the limactl smaller and faster to start up. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
|
This will break the other pending PRs, since they will need to add hostagent API - and not call the driver directly... But that is probably a good thing, even if it does make the hostagent slightly more complicated (more API calls) ? |
|
Can't we just fix the issue on Code-Hex/vz? |
Sure, it depends on what the root cause is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows linking only the hostagent with the driver libraries, while keeping the limactl smaller and faster to start up.
Probably needs to live in "libexec" or something like that ? And maybe the subcommand should be renamed, too.
Closes #1209