Skip to content

adding python 3.8 test environment #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2020
Merged

adding python 3.8 test environment #96

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cdc95f9
adding python 3.8 test environment
Apr 20, 2020
86ff44e
fix typo
Apr 20, 2020
2379300
dont run regression until the other jobs are done
Apr 20, 2020
99fa7a2
fix workflow
Apr 20, 2020
9e881b2
bump version of python
Apr 20, 2020
f5a2eb9
add cache
Apr 21, 2020
c653cc1
remove commented out config
Apr 21, 2020
d45a4ac
disabling max throughput test, its completely inconsistent
Apr 21, 2020
bf84034
adding FIXME to re-enable max_throughput in the future
Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 78 additions & 23 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
version: 2
version: 2.1

commands:
restore_benchmark_cache:
description: "Restore pip and protos directories"
steps:
- restore_cache:
key: benchmark-cache-{{ checksum "~/lightstep-benchmarks/requirements-dev.txt" }}

save_benchmark_cache:
description: "Save pip and protos directories into cache for faster installs next time"
steps:
- save_cache:
key: benchmark-cache-{{ checksum "~/lightstep-benchmarks/requirements-dev.txt" }}
paths:
- "/root/.cache/pip"
- "~/protoc3"

jobs:
test-python2.7:
test-python27:
working_directory: ~/lightstep/lightstep-tracer-python
shell: /bin/bash --login
environment:
Expand All @@ -20,7 +37,7 @@ jobs:
- store_artifacts:
path: /tmp/circleci-test-results

test-python3.4:
test-python34:
working_directory: ~/lightstep/lightstep-tracer-python
shell: /bin/bash --login
environment:
Expand All @@ -40,7 +57,7 @@ jobs:
- store_artifacts:
path: /tmp/circleci-test-results

test-python3.5:
test-python35:
working_directory: ~/lightstep/lightstep-tracer-python
shell: /bin/bash --login
environment:
Expand All @@ -60,7 +77,7 @@ jobs:
- store_artifacts:
path: /tmp/circleci-test-results

test-python3.6:
test-python36:
working_directory: ~/lightstep/lightstep-tracer-python
shell: /bin/bash --login
environment:
Expand All @@ -80,7 +97,7 @@ jobs:
- store_artifacts:
path: /tmp/circleci-test-results

test-python3.7:
test-python37:
working_directory: ~/lightstep/lightstep-tracer-python
shell: /bin/bash --login
environment:
Expand All @@ -100,19 +117,44 @@ jobs:
- store_artifacts:
path: /tmp/circleci-test-results

test-python38:
working_directory: ~/lightstep/lightstep-tracer-python
shell: /bin/bash --login
environment:
CIRCLE_ARTIFACTS: /tmp/circleci-artifacts
CIRCLE_TEST_REPORTS: /tmp/circleci-test-results
docker:
- image: circleci/python:3.8
steps:
- checkout
- run: mkdir -p $CIRCLE_ARTIFACTS $CIRCLE_TEST_REPORTS
- run: sudo pip install tox
- run: make test38
- store_test_results:
path: /tmp/circleci-test-results
- store_artifacts:
path: /tmp/circleci-artifacts
- store_artifacts:
path: /tmp/circleci-test-results

regression_test:
resource_class: xlarge
docker:
- image: circleci/python:3.7.4
- image: circleci/python:3.7.7
working_directory: ~/repo
steps:
- checkout
- run: cd ~; ~/repo/ci/clone_lightstep_benchmarks.sh
- restore_benchmark_cache
- run: ~/lightstep-benchmarks/scripts/ci_setup.sh
- save_benchmark_cache
- run: sudo pip install -e ~/repo
- run: |
cd ~/lightstep-benchmarks/
pytest -s --client_name python regression_tests.py
pytest -s --client_name python regression_tests.py::test_max_throughput
pytest -s --client_name python regression_tests.py::test_memory
pytest -s --client_name python regression_tests.py::test_dropped_spans
pytest -s --client_name python regression_tests.py::test_cpu
- store_artifacts:
path: ~/lightstep-benchmarks/logs
destination: logs
Expand Down Expand Up @@ -193,23 +235,36 @@ workflows:
version: 2
test:
jobs:
- test-python2.7
- test-python3.4
- test-python3.5
- test-python3.6
- test-python3.7
- regression_test
- approve_make_graphs:
type: approval
- make_dropped_graphs:
- test-python27:
requires:
- regression_test
- test-python34:
requires:
- regression_test
- test-python35:
requires:
- approve_make_graphs
- make_memory_graphs:
- regression_test
- test-python36:
requires:
- approve_make_graphs
- make_disconnect_graphs:
- regression_test
- test-python37:
requires:
- approve_make_graphs
- make_cpu_graphs:
- regression_test
- test-python38:
requires:
- approve_make_graphs
- regression_test
# - approve_make_graphs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest these comments are removed.

# type: approval
# - make_dropped_graphs:
# requires:
# - approve_make_graphs
# - make_memory_graphs:
# requires:
# - approve_make_graphs
# - make_disconnect_graphs:
# requires:
# - approve_make_graphs
# - make_cpu_graphs:
# requires:
# - approve_make_graphs
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ test36: build
test37: build
tox -e py37

test38: build
tox -e py38

test: build
tox

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py27, py34, py35, py36, py37, py37-tracecontext
envlist = py27, py34, py35, py36, py37, py37-tracecontext, py38

[testenv]
deps =
Expand Down