Skip to content

adding python 3.8 test environment #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 21, 2020
Merged

adding python 3.8 test environment #96

merged 9 commits into from
Apr 21, 2020

Conversation

codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten requested a review from ocelotl April 20, 2020 17:35
ocelotl
ocelotl suggested changes Apr 21, 2020
View reviewed changes
.circleci/config.yml Outdated
requires:
- approve_make_graphs
- regression_test
# - approve_make_graphs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest these comments are removed.

@codeboten codeboten requested a review from ocelotl April 21, 2020 16:55
ocelotl
ocelotl approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 😎

@codeboten codeboten merged commit 540768e into master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codeboten @ocelotl