discovery: flag flip no historical gossip#3359
Merged
Roasbeef merged 4 commits intolightningnetwork:masterfrom Aug 2, 2019
Merged
discovery: flag flip no historical gossip#3359Roasbeef merged 4 commits intolightningnetwork:masterfrom
Roasbeef merged 4 commits intolightningnetwork:masterfrom
Conversation
cfromknecht
changed the title
wpaulino
approved these changes
Jul 30, 2019
Contributor
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
LGTM 💫
Looks like Eclair also sends out the current timestamp as the start of the range, though c-lightning can vary depending on how much gossip they've ingested.
wpaulino
added
config
Roasbeef
requested changes
Jul 31, 2019
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
Pretty compact diff, reads well at first pass through. Only main comment is to add a new test to exercise ignoring the backlog for a gossip syncer if the new flag is set.
cfromknecht
force-pushed
the
flag-flip-no-historical-gossip
branch
from
05dd494 to
09a46dc
Compare
This commit adds the ignore-historical-filters CLI option, initially defaulting to false. Users may use this option to prevent lnd from doing historical gossip dumps to peers that set their `gossip_timestamp_range` in the past. Enabling this option will result in lower bandwidth and memory consumption. Down the road the plan is to make this default to true.
cfromknecht
force-pushed
the
flag-flip-no-historical-gossip
branch
from
09a46dc to
9947190
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
ignore-historical-filtersCLI option, initiallydefaulting to false. Users may use this option to prevent lnd from doing
historical gossip dumps to peers that set their
gossip_timestamp_rangein the past. Enabling this option will result in lower bandwidth and
memory consumption. Down the road the plan is to make this default to
true.