discovery: don't reply with historical updates to gossip filters#3315
Closed
cfromknecht wants to merge 3 commits intolightningnetwork:masterfrom
Closed
discovery: don't reply with historical updates to gossip filters#3315cfromknecht wants to merge 3 commits intolightningnetwork:masterfrom
cfromknecht wants to merge 3 commits intolightningnetwork:masterfrom
Conversation
Contributor
Author
|
This is an example of the changes proposed in lightning/bolts#641 |
cfromknecht
force-pushed
the
no-historical-gossip-filter
branch
2 times, most recently
from
84d4755 to
a65fb18
Compare
Contributor
Author
|
we may also be able to remove |
This commit removes the existing behavior that responds with all known updates when a remote peer sends a gossip_timestamp_filter. When a peer sets this with a very old start timestamp, this can cause the local node to dump the entire graph to the peer, which is functionally equivalent to the original `intitial_routing_sync` feature. That feature was deprecated because it is expensive and can force a node to use a disproportionate amount of resources, especially on flapping connections. Now, the filter is only applied to new gossip messages when deciding whether or not to forward them to a particular peer.
This method can no longer fail since it doesn't interact with the db.
cfromknecht
force-pushed
the
no-historical-gossip-filter
branch
from
a65fb18 to
d31b6c7
Compare
Roasbeef
added
dos/hardening
Contributor
Author
|
parking this until 0.9 cycle, will be superceded by #3359 in the meantime |
Member
|
#3359 has been since merged, so I think this is no longer relevant? |
Collaborator
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the existing behavior that responds with all known
updates when a remote peer sends a gossip_timestamp_filter. When a peer
sets this with a very old start timestamp, this can cause the local node
to dump the entire graph to the peer, which is functionally equivalent
to the original
intitial_routing_syncfeature. That feature wasdeprecated because it is expensive and can force a node to use a
disproportionate amount of resources, especially on flapping
connections. Now, the filter is only applied to new gossip messages when
deciding whether or not to forward them to a particular peer.