Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tor v3 address support for Neutrino client mode #4973

Closed
bitcoinlizard opened this issue Jan 31, 2021 · 9 comments · Fixed by #6468
Closed

Enable Tor v3 address support for Neutrino client mode #4973

bitcoinlizard opened this issue Jan 31, 2021 · 9 comments · Fixed by #6468
Assignees
Labels
enhancement Improvements to existing features / behaviour neutrino Lightweight neutrino backend-type P2 should be fixed if one has time tor
Milestone

Comments

@bitcoinlizard
Copy link

Background

Tor v3 address are not supported in Neutrino client mode. This is discussed in the first comment here:

#4806

This is more relevant as bitcoind recently released version 0.21.0 which adds support for serving compact filters to peers. Bitcoind also switched to Tor v3 addresses as a default in version 0.21.0 (older versions only supported v2). Enabling Tor v3 address support could increase the number of Neutrino mode LND nodes deployed as there would be many more backends available.

@guggero guggero added enhancement Improvements to existing features / behaviour neutrino Lightweight neutrino backend-type P2 should be fixed if one has time tor labels Feb 1, 2021
@wpaulino wpaulino added this to the 0.13.0 milestone Feb 1, 2021
@Roasbeef
Copy link
Member

Roasbeef commented Feb 4, 2021

Note that in order to implement this, we'll need to implement the new addrv2 scheme within the btcsuite set of libraries. After we do that, neutrino will get this feature "for free".

@openoms
Copy link
Contributor

openoms commented Sep 28, 2021

Would like note that there is a time limit here:

https://blog.torproject.org/v2-deprecation-timeline

3. October 15th, 2021
We will release new Tor client stable versions for all supported series that will disable v2.

As mentioned here also: #5771 (comment)

@bitcoinlizard
Copy link
Author

A lot of Tor only Neutrino LND nodes are going to go offline in short order. I run a Tor v2 BTCD node and have at times seen 50+ Neutrino nodes connected to it. As I understand it the btcsuite upgrade will resolve the issue for both LND and BTCD.

@Roasbeef
Copy link
Member

We're aware of the time limit, but unfortunately this won't make it into 0.14 as slated. See the newly created milestone that tracks this inclusion.

As usual: contributions are accepted here. BIP 155 isn't too involved, but this fell through the cracks somewhat w/ all the other PR/issues and priorities.

@Roasbeef
Copy link
Member

Roasbeef commented Oct 1, 2021

Note that I have started a BIP 155 implementation, pretty confident I can finish it before the end of October (see the milestone this issue is attached to).

@nochiel
Copy link

nochiel commented Oct 1, 2021

Note that I have started a BIP 155 implementation, pretty confident I can finish it before the end of October (see the milestone this issue is attached to).

@Roasbeef Which branch in your repo should I look at for what you've implemented so far? I'd love to contribute and help get it done.

@Roasbeef
Copy link
Member

Roasbeef commented Feb 2, 2022

Update on this: we're in active testing, a PR should be up in the next few days!

@Roasbeef
Copy link
Member

The btcd PR (where most of this code lives), is here: btcsuite/btcd#1812

@tlindi tlindi mentioned this issue Mar 3, 2022
14 tasks
@Roasbeef Roasbeef self-assigned this Mar 7, 2022
@Roasbeef Roasbeef assigned Crypt-iQ and unassigned Roasbeef Apr 13, 2022
@Roasbeef
Copy link
Member

PR has been merged, so this is only blocked on the updates to the neutrino package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour neutrino Lightweight neutrino backend-type P2 should be fixed if one has time tor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants