Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor: deprecate --tor.v2 option for onion services #5771

Open
Roasbeef opened this issue Sep 20, 2021 · 3 comments
Open

tor: deprecate --tor.v2 option for onion services #5771

Roasbeef opened this issue Sep 20, 2021 · 3 comments
Assignees
Labels
compatibility config Parameters/arguments/config file related issues/PRs tor

Comments

@Roasbeef
Copy link
Member

The latest version of the Tor daemon won't connect to the "older" v2 onion service addresses. Instead, it'll only allow users to connect out to and create (?) v3 onion services. In roughly 2 weeks, Tor will release a new version of the client that will disable support for v2 onion services: https://support.torproject.org/onionservices/v2-deprecation/#:~:text=In%20July%202021%2C%200.4.,Service%20version%202%20deprecation%20timeline.

On our end, we mainly just need to remove the --tor.v2 arg and possibly add a new --tor.onion (or something) flag that selects the default since there no longer is a choice.

On the neutrino end, we still need to carry out this issue which is primarily a btcd/btcsuite issue as we need to add support for addrv2.

Spun off of: #5517 (comment)

@Roasbeef Roasbeef added config Parameters/arguments/config file related issues/PRs tor compatibility labels Sep 20, 2021
@Roasbeef
Copy link
Member Author

If we detect that a user is running a new enough version of Tor that doesn't support v2 any longer, then we can also automatically (?) convert their v2 addr into a v3 (well just make a new one really) and advertise that on the network instead.

@Roasbeef
Copy link
Member Author

Ran a quick script to see how many v2 nodes would be affected:

num nodes:  12844
num tor:  8793
num num v2:  66
num num v3:  8777

Looks like not many which is great, so perhaps we can just go w/ the option of removing the option and converting them to v3 (if their Tor daemon supports it, but I think those that do will be out of consensus come October?).

@starius
Copy link
Collaborator

starius commented Jan 22, 2024

It seems that v2 addresses haven't been used for a year now:

hidserv-dir-onions-seen-2021-10-24-2024-01-22

I suggest to deprecate the option and print a warning in case it is used.
And later remove v2 from the code. I think it is already dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility config Parameters/arguments/config file related issues/PRs tor
Projects
None yet
Development

No branches or pull requests

3 participants