RPC: Remove anchor_txid from AnchorInfo
#663
Conversation
itest/assertions.go
Outdated
|
|
||
| if a.ChainAnchor.AnchorTxid != txid.String() { | ||
| anchorTxid := | ||
| strings.Split(a.ChainAnchor.AnchorOutpoint, ":")[0] |
There was a problem hiding this comment.
Since the txid info was duplicate I now retrieve it by splitting the outpoint string
There was a problem hiding this comment.
I think you should use wire.NewOutPointFromString here.
There was a problem hiding this comment.
Good call, is the hash reversed in the raw outpoint string?
There was a problem hiding this comment.
Yes, the outpoint string consists of the txid and the vout index. The txid in the outpoint string is a hex encoding of the byte reversed hash.
|
There was a flake on a batch mint assets test, kicked it and passed, just flagging |
itest/assertions.go
Outdated
|
|
||
| if a.ChainAnchor.AnchorTxid != txid.String() { | ||
| anchorTxid := | ||
| strings.Split(a.ChainAnchor.AnchorOutpoint, ":")[0] |
There was a problem hiding this comment.
I think you should use wire.NewOutPointFromString here.
GeorgeTsagk
force-pushed
the
rpc-remove-anchor-txid
branch
from
b45fa51 to
8f7b0c1
Compare
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
Looks good to me! Just two or so nits.
I'm a fan of this change because it reduces our test surface.
GeorgeTsagk
force-pushed
the
rpc-remove-anchor-txid
branch
from
8f7b0c1 to
da6dcea
Compare
3 participants
Closes #654