Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove field anchor_txid from RPC message AnchorInfo. #654

Closed
ffranr opened this issue Nov 3, 2023 · 1 comment · Fixed by #663
Closed

Remove field anchor_txid from RPC message AnchorInfo. #654

ffranr opened this issue Nov 3, 2023 · 1 comment · Fixed by #663
Assignees
@GeorgeTsagk
Labels
enhancement New feature or request good first issue Good for newcomers gRPC refactoring
Milestone
v0.3.1

Comments

@ffranr
Copy link
Contributor

ffranr commented Nov 3, 2023

The txid is included in field anchor_outpoint. We should therefore remove field anchor_txid from the AnchorInfo RPC message.
@ffranr ffranr added enhancement New feature or request refactoring good first issue Good for newcomers gRPC labels Nov 3, 2023
@Roasbeef Roasbeef added this to the v0.3.1 milestone Nov 6, 2023
@ffranr
Copy link
Contributor Author

ffranr commented Nov 8, 2023

@GeorgeTsagk I think we should remove the field tapdb.ChainAsset.AnchorTxid at the same time (that struct has AnchorOutpoint). AnchorInfo and tapdb.ChainAsset are used in similar places.

@ffranr ffranr mentioned this issue Nov 8, 2023
Closed
@GeorgeTsagk GeorgeTsagk mentioned this issue Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeTsagk GeorgeTsagk

Labels
enhancement New feature or request good first issue Good for newcomers gRPC refactoring
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

RPC: Remove anchor_txid from AnchorInfo GeorgeTsagk/taproot-assets
3 participants
@Roasbeef @ffranr @GeorgeTsagk