lndclient: block until chain notifier is ready #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LND commit c6f458e478f9 (v0.20.0-rc3) moved ChainNotifier startup later in the lifecycle, so RegisterBlockEpochNtfn callers now see "chain notifier RPC is still in the process of starting" coming from Recv(). The new BlockUntilChainNotifier config option repeatedly calls RegisterBlockEpochNtfn during startup and only proceeds once the stream yields its first block height, retrying solely when we detect the ErrChainNotifierServerNotActive condition introduced by the LND commit above. The wait is guarded by a "chainrpc" build-tag check, so deployments without the ChainNotifier service fail fast when the option is requested.
starius
force-pushed
the
block-until-chain-notifier-is-ready
branch
from
e581dc3 to
be4fd2c
Compare
starius
added a commit
to starius/loop
that referenced
this pull request
Nov 10, 2025
Include lightninglabs/lndclient#255 TODO: remove replace
starius
added a commit
to starius/loop
that referenced
this pull request
Nov 10, 2025
starius
added a commit
to starius/loop
that referenced
this pull request
Nov 10, 2025
Include lightninglabs/lndclient#255 TODO: remove replace
starius
added a commit
to starius/loop
that referenced
this pull request
Nov 10, 2025
mohamedawnallah
approved these changes
Nov 10, 2025
mohamedawnallah
left a comment
mohamedawnallah
left a comment
There was a problem hiding this comment.
Thanks, LGTM!
LND commit lightningnetwork/lnd@c6f458e (v0.20.0-rc3) moved ChainNotifier startup later in the lifecycle
By the way, this commit (lightningnetwork/lnd@c6f458e) in LND v0.20.0-rc3 moved ChainNotifier startup back to its original location from LND v0.18.5. This location was changed in the first release candidate for LND v0.19.0, and this commit reverts it back to the v0.18.5 proper behavior
|
|
||
| // If requested, wait until the chain notifier RPC is ready before we | ||
| // return. This ensures sub-servers relying on the notifier don't fail | ||
| // during startup. |
starius
added a commit
to starius/loop
that referenced
this pull request
Nov 10, 2025
Include lightninglabs/lndclient#255 TODO: remove replace
starius
added a commit
to starius/loop
that referenced
this pull request
Nov 10, 2025
starius
added a commit
to starius/lightning-terminal
that referenced
this pull request
Nov 10, 2025
Include lightninglabs/lndclient#255 Include lightninglabs/loop#1039 wait for chain notifier
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LND commit lightningnetwork/lnd@c6f458e (v0.20.0-rc3) moved ChainNotifier startup later in the lifecycle, so RegisterBlockEpochNtfn callers now see "chain notifier RPC is still in the process of starting" coming from Recv().
The new BlockUntilChainNotifier config option repeatedly calls RegisterBlockEpochNtfn during startup and only proceeds once the stream yields its first block height, retrying solely when we detect the ErrChainNotifierServerNotActive condition introduced by the LND commit above.
The wait is guarded by a "chainrpc" build-tag check, so deployments without the ChainNotifier service fail fast when the option is requested.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.