[WIP] [check CI] 2025 10 litd v0 16 0 rc1 wait for chainnotifier #1170
+21
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include lightninglabs/lndclient#255 Include lightninglabs/loop#1039 wait for chain notifier
ViktorT-11
reviewed
Nov 11, 2025
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Thanks a lot 🙏, this looks great! LGTM once the dependent lndclient (+ potentially loop) PR has been shipped, so that we can remove the replaces before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if lightninglabs/lndclient#255 and lightninglabs/loop#1039 fix the issues with chain notifier not ready yet.
Use new option BlockUntilChainNotifier in LiT itself and in Loop.
Bump LND to v0.20.0-beta.rc3 which is known to have the regression in LiT itests (since commit lightningnetwork/lnd@c6f458e ).