Skip to content

Conversation

guarin
Copy link
Contributor

@guarin guarin commented Apr 26, 2023

Changes

  • Add tests for OnlineLinearClassifier

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.38 🎉

Comparison is base (d75df4e) 88.24% compared to head (990acad) 88.62%.

Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           guarin-lig-3049-add-simclr-imagenet-resnet50-benchmark    #1170      +/-   ##
==========================================================================================
+ Coverage                                                   88.24%   88.62%   +0.38%     
==========================================================================================
  Files                                                         139      139              
  Lines                                                        5774     5774              
==========================================================================================
+ Hits                                                         5095     5117      +22     
+ Misses                                                        679      657      -22     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guarin guarin merged commit 9a97707 into guarin-lig-3049-add-simclr-imagenet-resnet50-benchmark Apr 28, 2023
@guarin guarin deleted the guarin-lig-3049-add-online-linear-classifier-tests branch April 28, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants