This repository was archived by the owner on May 25, 2023. It is now read-only.
Only push when Docker plugin enabled and registry defined #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Self merging, let me know if there's anything you think should change @fsat. |
fsat
reviewed
Nov 20, 2017
| inConfig(docker.DockerPlugin.autoImport.Docker)( | ||
| publish in docker.DockerPlugin.autoImport.Docker := { | ||
| Def.taskDyn { | ||
| dockerRepository.?.value.nonEmpty && rpDockerPublish.?.value.nonEmpty |
There was a problem hiding this comment.
Does this statement actually do anything? If this evaluates to false, Def.task() will still be returned?
There was a problem hiding this comment.
Yeah, but I agree it's confusing -- shame on me! The && is there to just short-circuit evaluation of rpDockerPublish.?.value if dockerRepository.?.value is None. rpDockerPublish.?.value will evaluate the rpDockerPublish task (which returns empty) if it's defined.
I've filed #24 to fix this up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redefines the
publish in Dockertask to only publish for tasks that enable theDockerplugin and define a registry.This leads to a much better experience for lagom projects where users will have the api projects and running
docker:publishwould lead to many error messages for them, as it would be falling back to the defaultpublishimplementation for the API projects which is likely to fail.