Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Conversation

dwijnand
Copy link
Contributor

@dwijnand dwijnand commented Oct 9, 2018

In ff298c8 I tried to more accurately
model what I assumed was the intended behaviour, by wrapping the
invocation of rpDockerPublish in a Task. In doing so, however, I
dropped the .?, which originally allowed for rpDockerPublish to be
undefined. This caused a regression.

At this point I'm not sure why SbtReactiveAppPluginAll even exists. Why
not redefine publish in Docker in SbtReactiveAppPlugin, where
rpDockerPublish is actually defined? I went with the smaller change.

In ff298c8 I tried to more accurately
model what I assumed was the intended behaviour, by wrapping the
invocation of rpDockerPublish in a Task.  In doing so, however, I
dropped the .?, which originally allowed for rpDockerPublish to be
undefined.  This caused a regression.

At this point I'm not sure why SbtReactiveAppPluginAll even exists.  Why
not redefine publish in Docker in SbtReactiveAppPlugin, where
rpDockerPublish is actually defined?  I went with the smaller change.
@ghost ghost assigned dwijnand Oct 9, 2018
@ghost ghost added the review label Oct 9, 2018
@eed3si9n
Copy link
Contributor

eed3si9n commented Oct 9, 2018

Ref #19 "Only push when Docker plugin enabled and registry defined"

This redefines the publish in Docker task to only publish for tasks that enable the Docker plugin and define a registry.

This leads to a much better experience for Lagom projects where users will have the api projects and running docker:publish would lead to many error messages for them, as it would be falling back to the default publish implementation for the API projects which is likely to fail.

Ref #24 "Fix Cryptic code for shortcircuiting task"

Ref #143 "Clarify rpDockerPublish only if username & repo defined"

@ignasi35
Copy link
Contributor

ignasi35 commented Oct 9, 2018

thanks @dwijnand for the quick response on fixing this one!

@eed3si9n
Copy link
Contributor

I'm ok with merging for now, but we should remove the added magic on top of sbt-native-packager at some point.

@eed3si9n eed3si9n merged commit 378b63e into lightbend:master Oct 10, 2018
@ghost ghost removed the review label Oct 10, 2018
@dwijnand dwijnand deleted the handle-non-defined-rpDockerPublish branch October 10, 2018 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants