This repository was archived by the owner on May 25, 2023. It is now read-only.
Handle non-defined rpDockerPublish #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ff298c8 I tried to more accurately
model what I assumed was the intended behaviour, by wrapping the
invocation of rpDockerPublish in a Task. In doing so, however, I
dropped the .?, which originally allowed for rpDockerPublish to be
undefined. This caused a regression.
At this point I'm not sure why SbtReactiveAppPluginAll even exists. Why
not redefine publish in Docker in SbtReactiveAppPlugin, where
rpDockerPublish is actually defined? I went with the smaller change.