chore: bump to node v18.16 #490
Conversation
testkit/package.json
Outdated
| "types": "dist/index.d.ts", | ||
| "peerDependencies": { | ||
| "@kalix-io/kalix-javascript-sdk": "1.x" | ||
| "@kalix-io/kalix-javascript-sdk": "file:../sdk/kalix-io-kalix-javascript-sdk-0.0.0.tgz" |
There was a problem hiding this comment.
Absolutely. No idea how that happened though. Especially because it's on the package.json file.
I will check/revert/whatever needed
There was a problem hiding this comment.
I was looking around to understand how this got updated and it comes from ./bin/create-local-dependencies.sh script. This scripts seems to force the update in testkit/package.json. Not sure if this is intentional or desirable.
I will revert back to 1.x, but looking for guidance from someone with knowledge in the JS space.
There was a problem hiding this comment.
I remember Andrea saying something about the semantics of a lib file with 0.0.0 version. But I can recall the details. There was some trick/hack around it, but I'm not sure if that's what we need here.
Maybe @pvlugter or @katsutoxin can shed a light?
There was a problem hiding this comment.
The file create-local-dependencies.sh is created by @franciscolopezsancho , maybe he has better idea? I "guess" that file is only for local development, maybe we should not check in the change created by that file? (it is my personal guess)
There was a problem hiding this comment.
Yes, will just be for testing locally. Means that it's best to make changes and commit them, then run tests and discard the changes.
There was a problem hiding this comment.
wow, totally missed this comment. Sorry @katsutoxin. Yes, that file is only for local development.
octonato
force-pushed
the
octonato/bump-to-node-v18.16
branch
3 times, most recently
from
4c87074 to
46e215b
Compare
octonato
force-pushed
the
octonato/bump-to-node-v18.16
branch
from
46e215b to
6349d2a
Compare
|
It seems that I managed to make it green! 🎉 |
As suggested here https://github.com/lightbend/kalix-javascript-sdk/pull/459/files#r1177168357