Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

bump: Node 18 LTS #459

Merged
merged 6 commits into from
Apr 25, 2023
Merged

bump: Node 18 LTS #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bbaf328
bump: Bump node to LTS 18
johanandren Feb 9, 2023
cca0bbe
Updated package-lock files
johanandren Feb 9, 2023
ba97899
Right docker image in CI
johanandren Feb 9, 2023
47f7f60
And in nvmrc
johanandren Feb 9, 2023
02c6034
bump: npm audit fix:es
johanandren Mar 28, 2023
2213245
engine node: ~18
johanandren Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ jobs:

publish:
docker:
- image: cimg/node:14.16.1
- image: cimg/node:18.13.0
Copy link
Member

@pvlugter pvlugter Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now 18.16.0 — but that can be a separate bump.

steps:
- checkout
- run:
Expand Down Expand Up @@ -765,7 +765,7 @@ jobs:

npm-js-tests:
docker:
- image: cimg/node:14.16.1
- image: cimg/node:18.13.0
description: "npm-js-tests"
steps:
- checkout-and-merge-to-main
Expand Down Expand Up @@ -899,7 +899,7 @@ jobs:
working_directory: "~/tmp"
command: |
source /opt/circleci/.nvm/nvm.sh
nvm install v14
nvm install v18
export KALIX_NPMJS_SCRIPTS_VERSION="file:${HOME}/project/npm-js/kalix-scripts/kalix-io-kalix-scripts-0.0.0.tgz"
export KALIX_NPMJS_SDK_VERSION="file:${HOME}/project/sdk/kalix-io-kalix-javascript-sdk-0.0.0.tgz"
export KALIX_NPMJS_TESTKIT_VERSION="file:${HOME}/project/testkit/kalix-io-testkit-0.0.0.tgz"
Expand All @@ -910,7 +910,7 @@ jobs:
command: |
source /opt/circleci/.nvm/nvm.sh
export KALIX_NPMJS_CODEGEN_BINARY="${HOME}/project/codegen/js-gen-cli/target/native-image/kalix-codegen-js"
nvm install v14
nvm install v18
npm install && \
npm run build && \
npm run test
Expand All @@ -923,7 +923,7 @@ jobs:
shell: /bin/bash
command: |
source /opt/circleci/.nvm/nvm.sh
nvm install v14
nvm install v18
# Run proxy in background
sed -i docker-compose.yml -e "s/environment:/environment:\n VERSION_CHECK_ON_STARTUP: \"false\"/"
docker-compose up -d
Expand Down
2 changes: 1 addition & 1 deletion npm-js/create-kalix-entity/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v18
2 changes: 1 addition & 1 deletion npm-js/create-kalix-entity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Lightbend Inc",
"license": "Copyright (c) Lightbend Inc. 2021",
"engines": {
"node": ">=14.0.0",
"node": "~18",
"npm": ">=6.0.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion npm-js/create-kalix-entity/template/base-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.1",
"type": "module",
"engines": {
"node": ">=14.0.0",
"node": "~18",
"npm": ">=6.0.0"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions npm-js/create-kalix-entity/template/base-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "{{name}}",
"version": "0.0.1",
"engines": {
"node": ">=14.0.0",
"node": "~18",
"npm": ">=6.0.0"
},
"dependencies": {
Expand All @@ -13,7 +13,7 @@
"@kalix-io/testkit": "{{testkitVersion}}",
"@types/chai": "^4.3.1",
"@types/mocha": "^9.1.1",
"@types/node": "^18.0.0",
"@types/node": "^18.13.0",
"chai": "^4.3.6",
"mocha": "^10.0.0",
"ts-mocha": "^10.0.0",
Expand Down
2 changes: 1 addition & 1 deletion npm-js/kalix-scripts/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v18
158 changes: 114 additions & 44 deletions npm-js/kalix-scripts/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion npm-js/kalix-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Lightbend Inc",
"license": "Copyright (c) Lightbend Inc. 2021",
"engines": {
"node": ">=14.0.0",
"node": "~18",
"npm": ">=6.0.0"
},
"dependencies": {
Expand Down
Loading