fix(@clayui/css): Progress Bar sets a min-width on `progress-group-…
#4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…addon` to prevent resizing progress bar when numbers are changed to icons fix(@clayui/css): Progress Bar adds Sass map `$progress-group-addon` fixes liferay#4024
|
Just sanity-checking here, since the comment says "prevent resizing progress bar when numbers are changed to icons" but the progress bar also changes in size when the number goes from 1 (4%) to 2 digits (10%). Did this fix also addressed that case? |
|
@jbalsas Yes that is addressed. There is an issue when the number changes to 3 digits. It's really hard to tell, but would be fixed by setting the min-width to 40px instead of 32. |
pat270
added a commit
to pat270/clay
that referenced
this pull request
May 13, 2021
…re Cadmin got merged: liferay#3998, liferay#4002, liferay#4040, liferay#4055, liferay#4056, liferay#4060 fixes liferay#4064
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…addon` to prevent resizing progress bar when numbers are changed to icons
fix(@clayui/css): Progress Bar adds Sass map
$progress-group-addonfixes #4024