Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-130577 Update @clayui/* dependencies to v3.28.0 #1080

Closed

Conversation

matuzalemsteles
Copy link

Ticket: https://issues.liferay.com/browse/LPS-130577

3.28.0 (2021-05-19)

Bug Fixes

  • @clayui/css: Cadmin Alert adds .cadmin.alert-container selector (a104844)
  • @clayui/css: Cadmin Badges remove unused components inline-item and badge-pill (46868c7)
  • @clayui/css: Cadmin Button Groups remove unused components dropdown-toggle-split and btn-group-toggle (3fef3d5)
  • @clayui/css: Cadmin Cards remove unused components card-header-tabs, card-header-pills, card-deck, card-group, card-columns, accordion (06bdb00)
  • @clayui/css: Cadmin Dropdown remove unused component dropdown in navbar (e062006)
  • @clayui/css: Cadmin Form Validation remove unused components HTML 5 form validation (8cb7a19)
  • @clayui/css: Cadmin Forms remove unused components col-form-label, col-form-label-lg, col-form-label-sm, form-row, form-inline (81e1f4f)
  • @clayui/css: Cadmin Icons remove unused components lexicon-icon-sm, lexicon-icon-lg, lexicon-icon-xl (f0ee8fc)
  • @clayui/css: Cadmin Input Group remove styles related to custom-select, custom-file (cdf23e7)
  • @clayui/css: Cadmin Labels remove deprecated component inline-item (9ed5291)
  • @clayui/css: Cadmin List Group remove unused component list-group-horizontal (0b7f427)
  • @clayui/css: Cadmin merge Atlas variables with Cadmin base variables, we don't need two themes here (0eb6d29)
  • @clayui/css: Cadmin Modals remove unused component modal-dialog-scrollable (130dc5c)
  • @clayui/css: Cadmin move _reboot out of scoping selector, attribution text is causing empty selector to be output (ad36b85)
  • @clayui/css: Cadmin Navs remove unused component nav-pills (d27a7a1)
  • @clayui/css: Cadmin port changes to Clay CSS that were made before Cadmin got merged: #3998, #4002, #4040, #4055, #4056, #4060 (240bbc4), closes #4064
  • @clayui/css: Cadmin re-add widths for menubar and SF. Not sure what happened. (9142345)
  • @clayui/css: Cadmin remove unused components custom-switch, custom-select, custom-file, custom-range (fc447e2)
  • @clayui/css: Cadmin removes Atlas variables (4af356f)
  • @clayui/css: Cadmin removes components _root, _carousel, _jumbotron, _spinners, _toasts, _media, _application-bar, _drilldown, and _timelines. They are not used for Admin controls. (9ddeaed)
  • @clayui/css: Cadmin removes Sass docs comments (62e5541)
  • @clayui/css: Cadmin removes variables related to unused components (7ec35dc)
  • @clayui/css: Cadmin Side Navigation remove unused component container-fluid-1280 (41d8b50)
  • @clayui/css: Cadmin theme use selector .cadmin.component for components that render inside react portals. It's too difficult to put cadmin on the parent element. (640a662)
  • @clayui/css: Cadmin update Sass maps that use clay-select-variant to use new keys (c782615)
  • @clayui/css: Cadmin Utilities display utilities should also have .cadmin.d-{display} (4bb7a0a)
  • @clayui/css: Input Groups add btn-monospaced support for buttons inside input-group-inset-item (0d31b54), closes #4049
  • @clayui/css: Labels convert variables to use new Sass map keys (dcfc7c3)
  • @clayui/css: Management Bar Search button should be properly aligned in mobile view (1c3f583)
  • @clayui/css: Mixins border-radius shouldn't output the default radius if a null parameter is passed (42241df), closes #4066
  • @clayui/css: Mixins clay-label-size and clay-label-variant convert to use new (easier to remember) Sass map keys. The old keys will still work and win over new keys. (2123fdf), closes #4069
  • @clayui/css: Mixins clay-nav-variant convert to use new (easier to remember) Sass map keys. The old keys will still work and win over new keys. (3fa114a), closes #4071
  • @clayui/css: Mixins clay-select-variant update to use clay-css pattern, also deprecated keys should win over new keys (65ad45e)
  • @clayui/css: Mixins border-radius should use custom value first (5d30ab2)
  • @clayui/css: Restore default padding-left on ul, ol, dl that are undone by cadmin (1db5db7)
  • @clayui/css: Subnav Tbar labels should have $font-weight-normal by default (e1e36a6)
  • @clayui/css: Toggle Switch should be 48px wide (6735e54)

Features

  • @clayui/color-picker: Add the new DropDownContainerProps API (ac51bdd)
  • @clayui/css: Add form-extensions SVG icon (3061a9a)
  • @clayui/css: Add SVG icons chatbot and signature (7966c62)
  • @clayui/css: Cadmin theme convert rem values to px (2e33149)
  • @clayui/css: Created scoped version of Clay CSS for admin style isolation and prefix variables with $cadmin- (f1ae440)
  • @clayui/css: Functions and Mixins update to accept Clay CSS variables, Cadmin variables, or custom where applicable (b1eb431)
  • @clayui/drop-down: Add the new ContainerProps API (b106420)
  • @clayui/drop-down: Add the new ContainerProps API to the interface typing (31f38a9)
  • @clayui/modal: Add the new ContainerProps API (3a09e97)
  • @clayui/modal: do not set a default opener, ClayPortal handles it (23bcfba)
  • @clayui/modal: Rename variable name, allow to pass a container reference and add tests (c85fc25)
  • @clayui/modal: support custom opener for the modals (58a5bc5)
  • @clayui/popover: Add the new ContainerProps API (233a4f6)
  • @clayui/shared: add delegate event utility (f46b6ef)
  • @clayui/shared: Allow to pass className and/or id to the portal root element (132ab1e)
  • @clayui/shared: Extract to a function so the div is created with all its attributes (b7445bc)
  • @clayui/shared: simplify function (d326ace)
  • @clayui/tooltip: Add the new ContainerProps API (728600c)
  • @clayui/tooltip: update logic to handle scoping and a global listener (1c83d30)

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6bc7fd2f459143796553158ed227904c3f5663c0

Sender Branch:

Branch Name: LPS-130577
Branch GIT ID: d1cdd767055efa59699653f44697e633c2a8f99d

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 27 out of 35 jobs passed in 3 hours 30 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1197401_8358

Base Branch:

Branch Name: master
Branch GIT ID: 6bc7fd2f459143796553158ed227904c3f5663c0

Upstream Comparison:

Branch GIT ID: 6ef8246249d46947bd5589d0bca1f59afc60a7ad
Jenkins Build URL: Acceptance Upstream DXP (master) #1881

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 27 out of 35 jobs PASSED
27 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 6ef8246:
  1. ...
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@matuzalemsteles
Copy link
Author

Well, I investigated the tests that failed, but apparently it is not related, I will run the tests again

@matuzalemsteles
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 29 out of 35 jobs passed in 3 hours 57 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f620c75a2a63893f3d86f675cd35bc75ef980f2b

Upstream Comparison:

Branch GIT ID: f620c75a2a63893f3d86f675cd35bc75ef980f2b
Jenkins Build URL: Acceptance Upstream DXP (master) #1887

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 28 out of 35 jobs PASSED
28 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at f620c75:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    12 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=15,label_exp=!master #462302
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:headless:headless-delivery:headless-delivery-test:compileTestIntegrationJava'.
           [exec] > Compilation failed; see the compiler error output for details.
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:headless:headless-delivery:headless-delivery-test:compileTestIntegrationJava'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
           [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
           [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)
    2. AXIS_VARIABLE=16,label_exp=!master #462302
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:headless:headless-delivery:headless-delivery-test:compileTestIntegrationJava'.
           [exec] > Compilation failed; see the compiler error output for details.
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:headless:headless-delivery:headless-delivery-test:compileTestIntegrationJava'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
           [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
           [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)
    Click here for more failures.
  2. test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #386250
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:headless:headless-delivery:headless-delivery-test:compileTestIntegrationJava'.
           [exec] > Compilation failed; see the compiler error output for details.
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:headless:headless-delivery:headless-delivery-test:compileTestIntegrationJava'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
           [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
           [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)
  3. ...
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@matuzalemsteles
Copy link
Author

I'm not sure if anyone wants to review this since we are just updating the packages this time, I will leave it open until tomorrow, otherwise, I will be sending it forward 😁.

@bryceosterhaus
Copy link
Collaborator

LGTM!

Also, I used to forward if CI passed. It gets risky to wait due to package.json merge conflicts.

@matuzalemsteles
Copy link
Author

Thanks @bryceosterhaus, I was just hoping that someone else besides me, looks at this. I'll forward!

@matuzalemsteles
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#102142
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment