LPS-128822 Simplify

liferay · May 20, 2021 · f620c75 · f620c75
1 parent fb4f62a
commit f620c75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 23 deletions.
diff --git a/.../src/test/java/com/liferay/dynamic/data/mapping/storage/constants/FieldConstantsTest.java b/.../src/test/java/com/liferay/dynamic/data/mapping/storage/constants/FieldConstantsTest.java
@@ -39,8 +39,6 @@ public void testGetSerializableReturnDoubleWithLocaleBR() {
 		Serializable serializable = FieldConstants.getSerializable(
 			LocaleUtil.BRAZIL, LocaleUtil.BRAZIL, FieldConstants.DOUBLE, "3,0");
 
-		Assert.assertTrue(serializable instanceof Double);
-
 		Assert.assertEquals(Double.valueOf(3.0), (Double)serializable);
 	}
 
@@ -49,8 +47,6 @@ public void testGetSerializableReturnDoubleWithLocaleUS() {
 		Serializable serializable = FieldConstants.getSerializable(
 			LocaleUtil.US, LocaleUtil.US, FieldConstants.DOUBLE, "3.0");
 
-		Assert.assertTrue(serializable instanceof Double);
-
 		Assert.assertEquals(Double.valueOf(3.0), (Double)serializable);
 	}
 
@@ -59,8 +55,6 @@ public void testGetSerializableReturnIntegerWithLocaleBR() {
 		Serializable serializable = FieldConstants.getSerializable(
 			LocaleUtil.BRAZIL, LocaleUtil.BRAZIL, FieldConstants.INTEGER, "3");
 
-		Assert.assertTrue(serializable instanceof Integer);
-
 		Assert.assertEquals(Integer.valueOf(3), (Integer)serializable);
 	}
 
@@ -69,8 +63,6 @@ public void testGetSerializableReturnIntegerWithLocaleUS() {
 		Serializable serializable = FieldConstants.getSerializable(
 			LocaleUtil.US, LocaleUtil.US, FieldConstants.INTEGER, "3");
 
-		Assert.assertTrue(serializable instanceof Integer);
-
 		Assert.assertEquals(Integer.valueOf(3), (Integer)serializable);
 	}
 

diff --git a/...data-mapping-test/src/test/java/com/liferay/dynamic/data/mapping/util/NumberUtilTest.java b/...data-mapping-test/src/test/java/com/liferay/dynamic/data/mapping/util/NumberUtilTest.java
@@ -32,23 +32,11 @@ public class NumberUtilTest {
 		LiferayUnitTestRule.INSTANCE;
 
 	@Test
-	public void testGetDecimalSeparatorIndexUsingValueWithComma() {
+	public void testGetDecimalSeparatorIndex() {
+		Assert.assertEquals(-1, NumberUtil.getDecimalSeparatorIndex(""));
+		Assert.assertEquals(-1, NumberUtil.getDecimalSeparatorIndex("2"));
 		Assert.assertEquals(1, NumberUtil.getDecimalSeparatorIndex("2,0"));
-	}
-
-	@Test
-	public void testGetDecimalSeparatorIndexUsingValueWithDot() {
 		Assert.assertEquals(1, NumberUtil.getDecimalSeparatorIndex("2.0"));
 	}
 
-	@Test
-	public void testGetDecimalSeparatorIndexUsingValueWithNoSeparator() {
-		Assert.assertEquals(-1, NumberUtil.getDecimalSeparatorIndex("2"));
-	}
-
-	@Test
-	public void testGetDecimalSeparatorIndexWithEmptyValue() {
-		Assert.assertEquals(-1, NumberUtil.getDecimalSeparatorIndex(""));
-	}
-
 }