Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Scoped regression checkpoint at One ubuntu cgroup, exact-head detached worktree, fresh private HOME/CODEX_HOME/OPENCODEX_HOME/TMPDIR: CPUQuota=75%, MemoryHigh=1280M, MemoryMax=1536M, swap=0, TasksMax=64, IOWeight=20, nice=10, RuntimeMaxSec=120 and TimeoutStopSec=5. Effective limits were inspected; the workload terminated and protected real-home fingerprints/modes and the main dirty checkout were unchanged. I did not rerun your 561-test set, typecheck, docs/gates, interrupted changed suite or baseline comparisons. Preserve those broader failures/incomplete results as disclosed, not green evidence. Draft readiness remains 0/4 and Cross-platform CI New integration hold: trusted dev advanced to |
…#6584) (#6636) Devin rejected histories where several progress/final outputs for one tool call became separate tool prompts with the same call id. Consecutive results sharing a call id now merge into one prompt, keeping chunk order, images and error markers; any intervening message or a different id keeps chronological slots, and the parsed request is not mutated. Narrowed carry of #6584: consolidation never crosses an intervening turn. Co-authored-by: lidi1011 <283302260+lidi1011@users.noreply.github.com>
|
Thank you, @lidi1011. The consolidation for consecutive results of one invocation landed on |
Summary
Codex code-mode tools can append multiple progress/final outputs for one
call_id, including a late output after a new user message. The Devin mapper currently serializes each output as another tool prompt with the same ID. A supplied reproduction report observedinvalid_argumentfor this shape and success when the results were manually combined.Verification
Validated against upstream
devata6bc60816cc1b51c4279defa41c7ff2d2370d47ewith Bun 1.4.0 in an isolated source checkout.dev; the new nine-case suite failed 9/9 before the fix and passes 9/9 after it.bun test tests/providers/devin-*.test.ts tests/claude-integration/claude-devin-output-order.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/ci-workflows/structure-ssot.test.ts— 561 pass, 0 fail, 26 files. Includes actual protobuf prompt-count, call-ID, image-field and error-flag assertions.bun run typecheck— passed.bun run structure:check— passed.bun run privacy:scan— passed.cd docs-site && ASTRO_TELEMETRY_DISABLED=1 bun run build— passed; 561 pages built and internal links checked. Telemetry is disabled to keep the build within the isolated checkout.bun run test:changed— incomplete, not green. Stopped after more than six minutes: the captured output contains 12,309 passing cases, 34 skipped cases and 12 failures;tests/codex-integration/issue-452-empty-503.test.tswas still running after 296 seconds at interruption. The test runner buffers output until exit. Broader validation remains for CI; no full-suite success is claimed.bun test --isolate tests/adapters/anthropic/anthropic-fast-opt-in.test.ts tests/server/management-provider-validation.test.ts tests/claude-integration/claude-picker-runtime.test.ts tests/codex-integration/native-codex-toggle.test.ts— 172 pass / 11 fail on pristine upstreama6bc6081and the same 172 pass / 11 fail on PR head0ec00fcd, with identical failing test names. These failures concern provider-management HTTP status and native Codex toggle state. The twelfth failure (picker port-release timing) did not reproduce on either revision in this isolated rerun. The long-running empty-503 test was not rerun. These unrelated areas are left unchanged.No fresh paid provider request was sent and no installed proxy was patched or restarted. The original report's live before/after results are supporting evidence supplied by the reporter, not a live result independently reproduced in this PR. This fixes the duplicate-result shape, not every possible
invalid_argument. The full suite and upstream CI are not claimed as passing; this contributor PR remains a draft pending the repository's review-readiness process.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.