Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend translation comments based on crowdin feedback #835

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

tom-anders
Copy link
Contributor

@tom-anders tom-anders commented Jul 6, 2024

This adresses most of the feedback I've seen on crowdin about the new mobile-only texts

I've seen some discussion about this on crowdin. Since the app does not have any translation keys for "Puzzle Streak" and "Puzzle Storm" (and neither does lichess.org), we should add notes that these should also not be translated in other texts.
I've seen a question about this on crowdin.
(again, there are questions about this on crowdin)
@tom-anders tom-anders changed the title Add note to not translate "Puzzle Storm" and "Puzzle Streak" Extend translation comments based on crowdin feedback Jul 6, 2024
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@veloce veloce merged commit 82b66c9 into lichess-org:main Jul 8, 2024
1 check passed
@tom-anders tom-anders deleted the patch-1 branch July 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants