Skip to content

Corrected printing of footer (last_comment) in dep.pl #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Corrected printing of footer (last_comment) in dep.pl #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dep.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@
if ($apply == 1) {
print {$out} << 'EOS';
#endif
/* ref: \$Format:\%D$ */
/* git commit: \$Format:\%H$ */
/* commit time: \$Format:\%ai$ */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just get rid of these footers? I think these are obsolete in git. With SVN such comments were very popular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With SVN such comments were very popular

No, they weren't just popular, they were absolutely needed! ;-)

But you are right, they are not really needed anymore with git. Hands up who is still using them?
*puts hands in pockets*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find them useless and distracting. They are also never expanded in my git checkouts. Probably git must be configured somehow, but I never bothered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know when these are meant to be expanded. For releases? If they would be changed every time that would be some unnecessary disk IO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then - I wouldn't want release files to have different checksums than the files in git. I have no idea what the tags are for. Maybe I should think more before I hit enter.

/* ref: $Format:%D$ */
/* git commit: $Format:%H$ */
/* commit time: $Format:%ai$ */
EOS
}
close $src;
Expand Down