Corrected printing of footer (last_comment) in dep.pl #210
Conversation
| @@ -81,9 +81,9 @@ | |||
| if ($apply == 1) { | |||
| print {$out} << 'EOS'; | |||
| #endif | |||
| /* ref: \$Format:\%D$ */ | |||
| /* git commit: \$Format:\%H$ */ | |||
| /* commit time: \$Format:\%ai$ */ | |||
There was a problem hiding this comment.
Could we just get rid of these footers? I think these are obsolete in git. With SVN such comments were very popular.
There was a problem hiding this comment.
With SVN such comments were very popular
No, they weren't just popular, they were absolutely needed! ;-)
But you are right, they are not really needed anymore with git. Hands up who is still using them?
*puts hands in pockets*
There was a problem hiding this comment.
I find them useless and distracting. They are also never expanded in my git checkouts. Probably git must be configured somehow, but I never bothered.
There was a problem hiding this comment.
I don't even know when these are meant to be expanded. For releases? If they would be changed every time that would be some unnecessary disk IO.
There was a problem hiding this comment.
But then - I wouldn't want release files to have different checksums than the files in git. I have no idea what the tags are for. Maybe I should think more before I hit enter.
|
Ok to close? |
As the titel suggests, a correction in the printing of the footer.