-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Capture playback devices on wasapi #7803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture playback devices on wasapi #7803
Conversation
|
Hi! :) |
Was that for me? :) So what I want to do is make this use the same hint PulseAudio does: But also, the whole audio subsystem is about to look completely different when #7704 merges, so we should hold off on this a little longer and then incorporate the meat of this patch in once that's done. If this is urgent, then let's just merge it now and I'll do the reworking mentioned above as part of #7704. |
|
The hi was for verification on the SDL discord, we were slightly concerned about impersonation. Sorry for inadvertently getting your attentions icculus! This isn't urgent! |
|
The new audio subsystem is merged, so I expect to play around with this PR pretty soon. Just giving a status update here, you haven't been forgotten. :) |
|
Still want this, but I'm going to kick this to 3.2.0 (since it's not an ABI change)...but definitely want some form of this in the official first release. |
|
@playmer, can you update this PR for the latest main? |
|
Sure, didn't want to step on Ryan's toes. I'll try to take a look today. |
|
Please step on my toes, this is something we want for 3.4.0. |
df46791 to
6c0d3f5
Compare
|
Wanted to push up my initial port to actual SDL3, I've tested it with this and it seems to be working: https://gist.github.com/playmer/0437306c0d72b273f2f41144c0da3f71 (sorry, hardcoded audio devices, didn't want to do anything too fancy at the moment so just repurposed the simple_playback example) But I should probably take another look later this week with fresh eyes and make sure I'm not doing anything terrible. |
|
This PR is good. I have minor tweaks, but I'll fix those after merge. |
On the WASAPI backend, you can now call
SDL_OpenAudioDevicefor capture on playback devices.Description
SDL_AudioDriverImplto allow backends to declare the capability to capture playback devices.Existing Issue(s)
#7691