Add more known controllers to testevdev #7791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported by Rémi Bernon as an example of older SDL's non-udev code path going wrong for touchpads when the invoking user happens to be in the input group, which I believe was fixed by fdd945f. Signed-off-by: Simon McVittie <smcv@collabora.com>
We don't need to re-test the heuristic with the same input data, but knowing that another device has equivalent evdev metadata is useful information to record. Thanks to Jeremy Whiting. Signed-off-by: Simon McVittie <smcv@collabora.com>
This didn't include any buttons, which I assume was because I transcribed them incorrectly rather than reflecting reality. Confirmed against another Switch Pro Controller on a more recent kernel (thanks to Jeremy Whiting). Signed-off-by: Simon McVittie <smcv@collabora.com>
A newer evemu-describe transcript has this same controller with its buttons mapped differently, presumably a result of driver changes in the Linux kernel. Either way, we should recognise it as a gamepad. Thanks to Jeremy Whiting. Signed-off-by: Simon McVittie <smcv@collabora.com>
This is a bit unusual because it has a small number of what would ordinarily be keyboard keys. Thanks to Jeremy Whiting for recording this. Signed-off-by: Simon McVittie <smcv@collabora.com>
Like the Stadia controller, this is unusual because it represents the Share button as the Record key from a multimedia keyboard (as of Linux 6.2.11 with the xpad driver). Thanks to Jeremy Whiting. Signed-off-by: Simon McVittie <smcv@collabora.com>
Thanks to Jeremy Whiting. Signed-off-by: Simon McVittie <smcv@collabora.com>
Also make details of PS4 gamepads (which are very similar from an evdev point of view) more specific. Thanks to Sam Lantinga and Jeremy Whiting for recording these. Signed-off-by: Simon McVittie <smcv@collabora.com>
ValveSoftware/steam-devices#34 lists several more devices that are functionally equivalent to this one from the point of view of their evdev metadata. Thanks to apgrc. Signed-off-by: Simon McVittie <smcv@collabora.com>
Thanks to Jeremy Whiting. Signed-off-by: Simon McVittie <smcv@collabora.com>
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #7597, having broader test data helps to make sure our heuristic for detecting these won't regress.
A few of these controllers (coincidentally, all from my colleague Jeremy Whiting's collection of test devices) are detected as
SDL_UDEV_DEVICE_JOYSTICK | SDL_UDEV_DEVICE_KEYBOARDbecause one of their buttons has been mapped to what is normally a keyboard key:KEY_MENU, the "Windows 95 keyboard" right-click-menu key, normally found between right Alt and right CtrlKEY_RECORDI've assumed here that SDL is handling these devices as intended. (Is it?)
Thanks to Jeremy Whiting, Rémi Bernon, Sam Lantinga and apgrc for collecting this information.