Skip to content

add SDL_bsearch #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

add SDL_bsearch #5514

merged 1 commit into from
Apr 26, 2022

Conversation

sezero
Copy link
Contributor

@sezero sezero commented Apr 11, 2022

The necessity first came up in @creichen's PR #5481 where he worked
around it for now.

Tossing this here as a PR, so it won't get lost.

@sezero sezero requested review from slouken and icculus April 12, 2022 14:05
Copy link
Collaborator

@icculus icculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the dynapi Perl script still need the typedef thing? Other than that this is fine with me.

@sezero
Copy link
Contributor Author

sezero commented Apr 12, 2022

Does the dynapi Perl script still need the typedef thing?

The perl script is broken for this: I hand-edited the generated dynapi entry.

Other than that this is fine with me.

OK to push for 2.0.22 or wait after release?

@icculus
Copy link
Collaborator

icculus commented Apr 12, 2022

Wait on this one.

@icculus icculus added this to the 2.0.24 milestone Apr 12, 2022
@icculus icculus added the early in milestone This change should be made early in the milestone for additional testing label Apr 12, 2022
@slouken
Copy link
Collaborator

slouken commented Apr 25, 2022

Feel free to merge this whenever you're ready.

@sezero sezero merged commit e9ff4fd into libsdl-org:main Apr 26, 2022
@sezero sezero deleted the bsearch branch April 26, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early in milestone This change should be made early in the milestone for additional testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants