cocoa: Workaround for an issue with incorrect window position after exiting fullscreen#15921
Open
ZeroEightSix wants to merge 1 commit into
Open
cocoa: Workaround for an issue with incorrect window position after exiting fullscreen#15921ZeroEightSix wants to merge 1 commit into
ZeroEightSix wants to merge 1 commit into
Conversation
…xiting fullscreen on some displays Fix for libsdl-org#15920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, in some cases, the window can move to an incorrect position after exiting fullscreen
Description
In some cases the [NSMenu setMenuBarVisible:YES]; call in windowDidExitFullScreen: makes Cocoa call windowDidMove: with an incorrectly set window frame. [nswindow frame] in windowDidExitFullScreen: right before that setMenuBarVisible: call is correct.
Calling [NSMenu setMenuBarVisible:YES] in windowDidExitFullScreen: only if [NSMenu menuBarVisible] is false works around this problem.
Existing Issue(s)
#15920