Skip to content

Add support for GIP guitars via gameinput#15301

Open
sanjay900 wants to merge 5 commits intolibsdl-org:mainfrom
sanjay900:xb1-instrument-support
Open

Add support for GIP guitars via gameinput#15301
sanjay900 wants to merge 5 commits intolibsdl-org:mainfrom
sanjay900:xb1-instrument-support

Conversation

@sanjay900
Copy link
Copy Markdown
Contributor

@sanjay900 sanjay900 commented Apr 2, 2026 •
edited
Loading

Description

  • Add support for Xbox One (GIP) Guitars via GameInput
  • Add support for GameInput raw reports
  • Add a SDL_HINT_JOYSTICK_GAMEINPUT_RAW hint for enabling GameInput raw reports

Existing Issue(s)

@sanjay900
Copy link
Copy Markdown
Contributor Author

sanjay900 commented Apr 2, 2026 •
edited
Loading

I've started the work for other instruments too, but i will leave implementing drums until i tackle #14889, which im slowly working towards by first getting all the building blocks in to support all the instruments

@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch 6 times, most recently from b262971 to b659447 Compare April 2, 2026 02:15
@sanjay900 sanjay900 marked this pull request as draft April 2, 2026 06:14
@sanjay900 sanjay900 marked this pull request as ready for review April 2, 2026 06:14
@sanjay900 sanjay900 marked this pull request as draft April 2, 2026 06:17
@sanjay900 sanjay900 marked this pull request as ready for review April 2, 2026 06:30
@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch from f93591a to b659447 Compare April 2, 2026 06:39
slouken
slouken reviewed Apr 2, 2026
View reviewed changes
slouken
slouken reviewed Apr 2, 2026
View reviewed changes
@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch from b659447 to 3035655 Compare April 2, 2026 18:57
@sanjay900
Copy link
Copy Markdown
Contributor Author

sanjay900 commented Apr 2, 2026

Is that failure something ive done wrong, or just a random failure

@slouken
Copy link
Copy Markdown
Collaborator

slouken commented Apr 2, 2026

Is that failure something ive done wrong, or just a random failure

It's a random failure.

@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch from 3035655 to 2b97325 Compare April 2, 2026 21:16
@sanjay900
Copy link
Copy Markdown
Contributor Author

sanjay900 commented Apr 2, 2026

I have sliced off the changes from the other PR now

@sanjay900 sanjay900 changed the title Add support for xbone guitars via gameinput Add support for GIP guitars via gameinput Apr 2, 2026
@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch 4 times, most recently from ac78717 to bdce352 Compare April 2, 2026 22:28
@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch from bdce352 to aba77b7 Compare April 2, 2026 23:23
@sanjay900
Copy link
Copy Markdown
Contributor Author

sanjay900 commented Apr 2, 2026

This one should be good to go now too, though it requires the GameInput V3 merge

@sanjay900
Copy link
Copy Markdown
Contributor Author

sanjay900 commented Apr 2, 2026 •
edited
Loading

If its possible to sneak this and gameinput v3 into 3.4.4 that would be cool, since then i could update RPCS3 and have full instrument support from that end, but if thats not possible i get it

slouken
slouken reviewed Apr 3, 2026
View reviewed changes
slouken
slouken reviewed Apr 3, 2026
View reviewed changes
slouken
slouken reviewed Apr 3, 2026
View reviewed changes
@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch 3 times, most recently from 1e90d44 to e1a8bf6 Compare April 3, 2026 00:59
@sanjay900 sanjay900 force-pushed the xb1-instrument-support branch from e1a8bf6 to b8e70fa Compare April 3, 2026 01:04
@sanjay900
Copy link
Copy Markdown
Contributor Author

sanjay900 commented Apr 3, 2026 •
edited
Loading

Have just finished cleaning things up now after all those changes, seems a lot cleaner now, should be good to go now

slouken
slouken reviewed Apr 3, 2026
View reviewed changes
slouken
slouken reviewed Apr 3, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slouken slouken slouken left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanjay900 @slouken