cmake: test for EGL and GLES on Windows, avoid EGL test on MSVC #11244
+22
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MSVC platforms,
SDL3/SDL_egl.h
has the following conditional to avoid including a systemEGL/egl.h
:SDL/include/SDL3/SDL_egl.h
Line 28 in dd95533
Perhaps this should include Windows platforms?
If a CMake test is preferred, we were only detecting egl.h for the unix platforms.
This pr adds a test for the Windows platform.
When using MSVC, it avoids a check for
<EGL/egl.h>
and<EGL/eglext.h>
includes.It adds checks for
<GLES/gl.h>
and<GLES/glext.h>
includes inCheckOpenGLES
forSDL_VIDEO_OPENGL_ES
<GLES2/gl2.h>
and<GLES2/gl2ext.h>
includes inCheckOpenGLES
forSDL_VIDEO_OPENGL_ES2
The MSVC behavior should be the same, but please review.
Existing Issue(s)
Fixes #11216