Add testcase showing wShowWindow behavior in Windows #11129
+181
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
Oct 9, 2024
| /* The child process exits with code '1' when the window is minimized / maximized */ | ||
| DWORD exit_code = 0; | ||
| GetExitCodeProcess(pi.hProcess, &exit_code); | ||
| SDLTest_AssertCheck(exit_code == 0, "Child process failed with code %d!", exit_code); |
There was a problem hiding this comment.
Suggested change
| SDLTest_AssertCheck(exit_code == 0, "Child process failed with code %d!", exit_code); | |
| SDLTest_AssertCheck(exit_code == 0, "Child process failed with code %lu", exit_code); |
slouken
reviewed
Oct 9, 2024
| including commercial applications, and to alter it and redistribute it | ||
| freely. | ||
| */ | ||
| /* Sample program: Test SDL's ability to defuse the window state (minimized/maximized) that is applied on the initial window created. */ |
There was a problem hiding this comment.
Please note what bug this is a test case for.
madebr
reviewed
Oct 9, 2024
| } | ||
|
|
||
| if (consumed <= 0) { | ||
| static const char *options[] = { NULL }; |
There was a problem hiding this comment.
So it shows in --help.
Suggested change
| static const char *options[] = { NULL }; | |
| static const char *options[] = { "--child-spawn-dialog", NULL }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a testcase for #9434.
It shows that a process does not control all aspects of the initial window it creates.
(As-is there is no workaround provided yet, so the testcase fails)
Description
The initial window created in a process is influenced by the
wShowWindowflag passed in to CreateProcess.:STARTUPINFOA si = { sizeof(si) }; si.dwFlags = STARTF_USESHOWWINDOW; si.wShowWindow = SW_MAXIMIZE;This is used in the shell to provide the 'Minimized', 'Maximized' etc dropdown on shortcuts.