feat: mdns #260

salmad3 · 2022-12-05T04:58:56Z

Context

Adds content for libp2p mdns
Part of Create and populate discovery & routing section #250

Notes

Section this document lives under will become populated with corresponding PRs
Discovery section initiated in feat: rendezvous #259

Latest preview

Please view the latest Fleek preview here. (preview outdated as not against master anymore)

p-shahi · 2022-12-06T05:08:55Z

@jxs can you help review this?

(Took liberty of unassigning Marten to help spread the load.)

marten-seemann

It would probably be useful if you could run a kubo node and inspect the mDNS query and response using wireshark, and add (the relevant parts) to this document.

content/concepts/discovery/mDNS.md

marten-seemann · 2022-12-06T05:58:41Z

(Took liberty of unassigning Marten to help spread the load.)

@p-shahi Thank you, but I had already started my review, so I'm posting it anyway.

marten-seemann

There seems to be some misunderstanding of how mDNS works and what we're trying to achieve.

@DannyS03, have you tried Wiresharking the mDNS traffic originating from an IPFS node, and inspecting the packets? I think this could be really instructive. I also think (as I mentioned in my last review) that we should add some of that Wireshark output here as examples.

content/concepts/discovery/mDNS.md

content/concepts/discovery-routing/mDNS.md

marten-seemann · 2023-01-23T21:09:08Z

content/concepts/discovery-routing/mDNS.md

+| No. | Time       | Source IP                | Destination IP         | Protocol | Length | Info                      |
+|-----|------------|--------------------------|------------------------|----------|--------|---------------------------|
+| 1   | 0.000000   | 10.0.0.25                | 224.0.0.251            | MDNS     | 75     | Standard query 0x7d14 PTR _p2p._udp.local, "QM" question |
+| 2   | 0.000130   | fe80::8d9:f02f:717f:2c03 | ff02::fb               | MDNS     | 95     | Standard query 0x7d14 PTR _p2p._udp.local, "QM" question |
+| 3   | 0.002497   | 10.0.0.25                | 224.0.0.251            | MDNS     | 918    | Standard query response 0x7d14 PTR vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn._p2p._udp.local SRV 0 0 4001 vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn.local TXT A 127.0.0.1 AAAA ::1 |
+| 4   | 0.002507   | fe80::8d9:f02f:717f:2c03 | ff02::fb               | MDNS     | 938    | Standard query response 0x7d14 PTR vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn._p2p._udp.local SRV 0 0 4001 vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn.local TXT A 127.0.0.1 AAAA ::1 |


This doesn't show the multiaddr, does it?

If we're going to show this, we may as well show the multiaddr result of the query.

Yes, that was my motivation when I asked for including a Wireshark capture.

Maybe this could even be a screenshot of Wireshark? No strong opinion in either direction though.

Let's not include this? Why have wireshark output for mDNS and not for other protocols?

I'm in favor of removing this and the following paragraphs.

Instead we can describe the peer discover section https://github.com/libp2p/specs/blob/master/discovery/mdns.md#peer-discovery in two sentences and point to the spec

@MarcoPolo @marten-seemann please re-review. I removed the wireshark section and instead linked to the specs

content/concepts/discovery-routing/mDNS.md

MarcoPolo

Tapping marten out, and I'll review from here on out.

MarcoPolo · 2023-01-27T00:42:23Z

content/concepts/discovery-routing/mDNS.md

+| No. | Time       | Source IP                | Destination IP         | Protocol | Length | Info                      |
+|-----|------------|--------------------------|------------------------|----------|--------|---------------------------|
+| 1   | 0.000000   | 10.0.0.25                | 224.0.0.251            | MDNS     | 75     | Standard query 0x7d14 PTR _p2p._udp.local, "QM" question |
+| 2   | 0.000130   | fe80::8d9:f02f:717f:2c03 | ff02::fb               | MDNS     | 95     | Standard query 0x7d14 PTR _p2p._udp.local, "QM" question |
+| 3   | 0.002497   | 10.0.0.25                | 224.0.0.251            | MDNS     | 918    | Standard query response 0x7d14 PTR vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn._p2p._udp.local SRV 0 0 4001 vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn.local TXT A 127.0.0.1 AAAA ::1 |
+| 4   | 0.002507   | fe80::8d9:f02f:717f:2c03 | ff02::fb               | MDNS     | 938    | Standard query response 0x7d14 PTR vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn._p2p._udp.local SRV 0 0 4001 vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn.local TXT A 127.0.0.1 AAAA ::1 |


If we're going to show this, we may as well show the multiaddr result of the query.

content/concepts/discovery-routing/mDNS.md

p-shahi · 2023-02-02T20:48:46Z

content/concepts/discovery-routing/mDNS.md

+| No. | Time       | Source IP                | Destination IP         | Protocol | Length | Info                      |
+|-----|------------|--------------------------|------------------------|----------|--------|---------------------------|
+| 1   | 0.000000   | 10.0.0.25                | 224.0.0.251            | MDNS     | 75     | Standard query 0x7d14 PTR _p2p._udp.local, "QM" question |
+| 2   | 0.000130   | fe80::8d9:f02f:717f:2c03 | ff02::fb               | MDNS     | 95     | Standard query 0x7d14 PTR _p2p._udp.local, "QM" question |
+| 3   | 0.002497   | 10.0.0.25                | 224.0.0.251            | MDNS     | 918    | Standard query response 0x7d14 PTR vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn._p2p._udp.local SRV 0 0 4001 vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn.local TXT A 127.0.0.1 AAAA ::1 |
+| 4   | 0.002507   | fe80::8d9:f02f:717f:2c03 | ff02::fb               | MDNS     | 938    | Standard query response 0x7d14 PTR vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn._p2p._udp.local SRV 0 0 4001 vmvokx8c0b7rcjtx4e14iyaxw7otg05xyg954y5fnh1a9rderxtxycicgtj3nn.local TXT A 127.0.0.1 AAAA ::1 |


Let's not include this? Why have wireshark output for mDNS and not for other protocols?

I'm in favor of removing this and the following paragraphs.

Instead we can describe the peer discover section https://github.com/libp2p/specs/blob/master/discovery/mdns.md#peer-discovery in two sentences and point to the spec

MarcoPolo

@p-shahi could you please give this a once over before merging. ty!

add content for mdns

8c14a02

salmad3 marked this pull request as draft December 5, 2022 04:59

salmad3 linked an issue Dec 5, 2022 that may be closed by this pull request

Create and populate discovery & routing section #250

Closed

6 tasks

edits

fc8138a

salmad3 requested a review from marten-seemann December 5, 2022 09:11

salmad3 added the ready for review PR is ready for review label Dec 5, 2022

salmad3 marked this pull request as ready for review December 5, 2022 09:11

p-shahi requested review from jxs and removed request for marten-seemann December 6, 2022 05:08

marten-seemann requested changes Dec 6, 2022

View reviewed changes

salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Dec 6, 2022

incorporate PR feedback & simplify

cefa3b7

salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Dec 7, 2022

salmad3 requested a review from marten-seemann December 7, 2022 09:36

marten-seemann reviewed Dec 7, 2022

View reviewed changes

salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Dec 8, 2022

improve mdns content

d69c526

salmad3 marked this pull request as draft January 3, 2023 10:33

salmad3 changed the base branch from master to init/discovery-sec January 15, 2023 18:23

rename dir

1bdc32e

salmad3 marked this pull request as ready for review January 15, 2023 18:29

add missing examples sec

a0a9d4d

salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Jan 23, 2023

salmad3 requested a review from marten-seemann January 23, 2023 17:15

marten-seemann reviewed Jan 23, 2023

View reviewed changes

salmad3 added change request PR requires changes. P1 High and removed ready for review PR is ready for review labels Jan 24, 2023

MarcoPolo requested changes Jan 27, 2023

View reviewed changes

MarcoPolo requested a review from marten-seemann January 27, 2023 00:51

simplify in libp2p sec

ad507f8

p-shahi reviewed Feb 2, 2023

View reviewed changes

p-shahi and others added 2 commits February 13, 2023 11:42

Update content/concepts/discovery-routing/mDNS.md

1fcf774

remove wireshark

f00409b

p-shahi requested a review from MarcoPolo February 13, 2023 20:12

p-shahi approved these changes Feb 13, 2023

View reviewed changes

p-shahi removed P1 High change request PR requires changes. labels Feb 23, 2023

Edits

dc606c9

MarcoPolo approved these changes Feb 25, 2023

View reviewed changes

Update mDNS.md

21f82ac

p-shahi merged commit bfe091d into init/discovery-sec Feb 25, 2023

p-shahi mentioned this pull request Mar 1, 2023

feat: peer discovery and routing section #294

Merged

p-shahi pushed a commit that referenced this pull request Mar 1, 2023

feat: mdns (#260)

2b0f65b

feat: mdns #260

feat: mdns #260

Uh oh!

Conversation

salmad3 commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Notes

Latest preview

Uh oh!

p-shahi commented Dec 6, 2022

Uh oh!

marten-seemann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marten-seemann commented Dec 6, 2022

Uh oh!

marten-seemann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marten-seemann Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

MarcoPolo Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

marten-seemann Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

p-shahi Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

p-shahi Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MarcoPolo left a comment

Choose a reason for hiding this comment

Uh oh!

MarcoPolo Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

p-shahi Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

MarcoPolo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

salmad3 commented Dec 5, 2022 •

edited

Loading