feat: peer discovery and routing section #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link fixes and potential conflicts will be addressed in this PR once all associated material has been added. |
p-shahi
reviewed
Feb 2, 2023
Comment on lines
2
to
5
| title: "PubSub" | ||
| description: "." | ||
| weight: 225 | ||
| --- |
There was a problem hiding this comment.
I would move PubSub out of the discovery and routing section and instead place it a section like messaging. Pubsub can be employed for routing/discovery but it's more for message dissemination imo
There was a problem hiding this comment.
I intended to remove this (and didn't create another doc as a result), thanks!
salmad3
added
change request
salmad3
added
ready for review
p-shahi
changed the title
|
@p-shahi is this still planned to merge eventually? If so, I would push a couple of changes to the mdns document. |
|
@mxinden please push your changes. I will merge by end of week |
mxinden
reviewed
Mar 1, 2023
p-shahi
changed the title
Co-authored-by: Marco Munizaga <marco@marcopolo.io>
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
p-shahi
force-pushed
the
init/discovery-sec
branch
from
df8a52a to
a2f5e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs this PR introduces that were already approved
Context