Skip to content

Conversation

coandco
Copy link
Collaborator

@coandco coandco commented May 31, 2024

Currently libdns/dnsmadeeasy doesn't compile due to mismatched int/uint types. This casts them when converting so the module can work. Fixes #1 .

@Monviech
Copy link

Monviech commented Jun 5, 2024

@coandco I'm also interested in this. Can you do another commit to update all dependencies with:

go mod tidy

Afterwards when this is PR has been merged we could do a pseudo version in caddy-dns/dnsmadeeasy

Compare these PRs I made in another module:

libdns/netcup#1
caddy-dns/netcup#6

@Monviech
Copy link

Monviech commented Jun 5, 2024

Build works for me:

xcaddy build --with github.com/caddy-dns/dnsmadeeasy --with github.com/libdns/dnsmadeeasy=github.com/coandco/libdns-dnsmadeeasy@08e4cf6822c015235afbab30ba6d86185a2f98a7

@coandco
Copy link
Collaborator Author

coandco commented Jun 5, 2024

Out of curiosity, what does it take to get a module to be downloadable on the main Caddy download page, so you don't have to build it with xcaddy yourself?

@coandco
Copy link
Collaborator Author

coandco commented Jun 5, 2024

Build works for me:

xcaddy build --with github.com/caddy-dns/dnsmadeeasy --with github.com/libdns/dnsmadeeasy=github.com/coandco/libdns-dnsmadeeasy@08e4cf6822c015235afbab30ba6d86185a2f98a7

Previous to this I was using Caddy 2.7 with lego_deprecated get certs from dnsmadeeasy. I've now moved my setup to use Caddy 2.8 built with the above command, updated my Caddyfile to use the dns.providers.dnsmadeeasy provider, and removed the previously-cached certs from Caddy's storage. I can confirm that Caddy is able to successfully obtain a new Let's Encrypt cert with the the code in this PR.

Copy link

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Sorry I broke this. The joys of pre-1.0 software...)

@mholt
Copy link

mholt commented Jun 5, 2024

@coandco To add the Caddy plugin to the Caddy website, go to "Account" on the Caddy site and after registering/logging in, claim your package. Make sure to claim the caddy-dns module, not the libdns package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't compile - type mismatch

3 participants